Skip to content

[ENHANCEMENT] Use areaOpacity for sparkline from theme #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abelyakin wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[ENHANCEMENT] Use areaOpacity for sparkline from theme #546

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e31cc3
get area opacity from theme
Jan 29, 2026
92bf0c5
add areaOpacity to sparkline options
Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion statchart/src/StatChartBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ export const StatChartBase: FC<StatChartProps> = (props) => {

const clonedSparkLine = { ...sparkline };
if (colorMode === 'background_solid') {
clonedSparkLine.areaStyle = { color: WHITE_COLOR_CODE, opacity: 0.4 };
clonedSparkLine.areaStyle = { color: WHITE_COLOR_CODE, opacity: chartsTheme.sparkline.areaOpacity };
clonedSparkLine.lineStyle = { color: WHITE_COLOR_CODE, opacity: 1 };
}

Expand Down
2 changes: 1 addition & 1 deletion statchart/src/utils/data-transform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export function convertSparkline(
},
areaStyle: {
color,
opacity: 0.4,
opacity: chartsTheme.sparkline.areaOpacity,
Copy link
Copy Markdown
Member

@Gladorme Gladorme Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to have opacity defined in StatChartSparklineOptions too 🤔

Copy link
Copy Markdown
Contributor Author

@abelyakin abelyakin Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. I added areaOpacity to StatChartSparklineOptions and wired it as an override (theme as default) for consistency with width.

},
};
}
Loading