Skip to content

Add count#2458

Draft
nohwnd wants to merge 1 commit into
mainfrom
add-count
Draft

Add count#2458
nohwnd wants to merge 1 commit into
mainfrom
add-count

Conversation

@nohwnd

@nohwnd nohwnd commented May 17, 2024

Copy link
Copy Markdown
Member

Both approaches look pretty ugly, ideas?

image

image

Fix #2434

@fflaten

fflaten commented May 18, 2024

Copy link
Copy Markdown
Collaborator

I personally prefer tests before time.
Any of these less ugly?
image
image

Comment thread src/functions/Output.ps1
}

$humanTime = "$(Get-HumanTime ($_test.Duration)) ($(Get-HumanTime $_test.UserDuration)|$(Get-HumanTime $_test.FrameworkDuration))"
$humanTime = Get-HumanTime $_test.Duration

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also affects Detailed++. Intentional?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intentional, but will revert.

@nohwnd

nohwnd commented May 18, 2024

Copy link
Copy Markdown
Member Author

Good idea with (). How about tests.ps1 55 tests (22ms)?

@fflaten

fflaten commented May 18, 2024

Copy link
Copy Markdown
Collaborator

I'd prefer parentheses on the first element as it helps separate filename from details at a glance, especially without colored output (plaintext/colorblind/etc)

Don't have a strong opinion on whether it should contain testcount or duration. I guessed you felt tests made it messy which is why I opted for count above 🙂

@nohwnd

nohwnd commented Jan 9, 2025

Copy link
Copy Markdown
Member Author

/backport to rel/5.x.x

@github-actions

github-actions Bot commented Jan 9, 2025

Copy link
Copy Markdown

Started backporting to rel/5.x.x: https://github.com/pester/Pester/actions/runs/12698516948

@nohwnd

nohwnd commented Jan 9, 2025

Copy link
Copy Markdown
Member Author

/backport to rel/5.x.x

@github-actions

github-actions Bot commented Jan 9, 2025

Copy link
Copy Markdown

Started backporting to rel/5.x.x: https://github.com/pester/Pester/actions/runs/12698540492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test count to minimal view

2 participants