chore: remove deprecated claude.yml from standards#379
Conversation
Add a concurrency block to both the live dev-lead.yml and the standards/workflows/dev-lead.yml template so that at most one dev-lead dispatch run executes per repo at a time (ci-relay retains its ephemeral per-SHA slot). Matches the policy landed in .github-private. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
The claude.yml workflow template has been deprecated in favor of dev-lead.yml as the standard workflow for all org repos (PR #301). All repos have migrated to dev-lead.yml. This removes the obsolete template from the org-level standards directory.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe PR removes Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes a workflow file and introduces a concurrency configuration to the dev-lead.yml workflow. A review comment suggests scoping the concurrency group to specific pull requests or issues rather than using a single global group, which would otherwise block concurrent workflow runs across different pull requests in the repository.
| concurrency: | ||
| # One active run per repo; ci-relay (check_run) keeps an ephemeral per-SHA slot | ||
| # so it can fire immediately without blocking or being blocked by the dispatch queue. | ||
| group: >- | ||
| ${{ | ||
| github.event_name == 'check_run' && format('dev-lead-ci-relay-{0}', github.event.check_run.head_sha) || | ||
| 'dev-lead' | ||
| }} | ||
| cancel-in-progress: false |
There was a problem hiding this comment.
Using a single global 'dev-lead' concurrency group for all non-check_run events means that any activity (such as comments, reviews, or pushes) on one pull request or issue will block the agent from running on all other pull requests or issues in the repository. This can lead to significant delays and a poor developer experience in active repositories.
We can scope the concurrency group to the specific pull request or issue using github.event.pull_request.number or github.event.issue.number, falling back to 'global' only when neither is available (e.g., for repository dispatches).
concurrency:
# One active run per PR/issue; ci-relay (check_run) keeps an ephemeral per-SHA slot
# so it can fire immediately without blocking or being blocked by the dispatch queue.
group: >-
${
github.event_name == 'check_run' && format('dev-lead-ci-relay-{0}', github.event.check_run.head_sha) ||
format('dev-lead-{0}', github.event.pull_request.number || github.event.issue.number || 'global')
}}
cancel-in-progress: false![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77bd0c1b04
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,68 +0,0 @@ | |||
| # ───────────────────────────────────────────────────────────────────────────── | |||
There was a problem hiding this comment.
Because scripts/deploy-standard-workflows.sh still includes claude.yml in DEPLOYABLE_WORKFLOWS (lines 38-46), deleting this template makes the default deployment path hit the missing-template branch at lines 138-140 for every target repo, and --workflow claude.yml can no longer do anything useful. Please remove or replace that deployable entry as part of retiring this template so the org workflow sync does not emit errors for an intentionally removed file.
Useful? React with 👍 / 👎.
| github.event_name == 'check_run' && format('dev-lead-ci-relay-{0}', github.event.check_run.head_sha) || | ||
| 'dev-lead' | ||
| }} | ||
| cancel-in-progress: false |
There was a problem hiding this comment.
With this workflow-level concurrency, every non-check_run trigger shares the literal dev-lead group, but cancel-in-progress: false alone does not create a full FIFO queue: GitHub's concurrency docs say the default queue is single, so a newer pending run cancels and replaces any existing pending run unless queue: max is set. In a busy repo, while one dev-lead run is active, a PR review submission followed by an @mention or issue label can drop the first pending automation event before it runs.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Removes the deprecated claude.yml workflow template from the org standards catalog and updates the dev-lead.yml workflow templates to add a concurrency policy intended to limit agent runs to one active run per repo while allowing per-SHA check_run relay executions.
Changes:
- Added a top-level
concurrencyblock todev-lead.ymlworkflow templates (standards + repo copy). - Removed the obsolete
standards/workflows/claude.ymltemplate from the standards directory.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
standards/workflows/dev-lead.yml |
Adds concurrency grouping (static dev-lead, per-SHA for check_run). |
standards/workflows/claude.yml |
Deletes the deprecated Claude workflow template from standards. |
.github/workflows/dev-lead.yml |
Mirrors the same concurrency policy in the repo’s own dev-lead workflow stub. |
| concurrency: | ||
| # One active run per repo; ci-relay (check_run) keeps an ephemeral per-SHA slot | ||
| # so it can fire immediately without blocking or being blocked by the dispatch queue. | ||
| group: >- | ||
| ${{ |
Superseded by automated re-review at
|
Superseded by automated re-review at
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87f9c4c80f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,68 +0,0 @@ | |||
| # ───────────────────────────────────────────────────────────────────────────── | |||
There was a problem hiding this comment.
Deleting this template leaves several standards/remediation paths pointing at a file that no longer exists: standards/ci-standards.md:310 says standards/workflows/claude.yml is preserved for historical reference, standards/agent-standards.md:30 says immutable workflow files are adopted verbatim from standards/workflows/, and scripts/compliance-audit.sh:1258 still advertises claude.yml as an available template. Anyone following the standards or generated audit remediation now gets a 404/missing file for this documented path, so either keep an archived copy or update those catalogs/references as part of the removal.
Useful? React with 👍 / 👎.
|
Review — fix requested (cycle 3/3)The automated review identified the following issues. Please address each one: Findings to fixAutomated review — NEEDS HUMAN REVIEWRisk: MEDIUM SummaryTriage cleared this PR as low-risk, but a confirmation pass shows the deletion of Linked issue analysisNo linked issues. The PR description references PR #301 as the migration that retired Findings1. Incomplete cleanup — dangling references to Verified against the current head (
2. PR scope drift — RESOLVED at this SHA The prior cycles noted that the concurrency change to 3. Concurrency design (LOW) — RESOLVED here No longer in scope for this PR (see #2). Any follow-up on the CI statusAll required checks green or skipped: CodeQL, AgentShield, Lint, ShellCheck, Agent Security Scan, Secret scan (gitleaks), SonarCloud (Quality Gate passed, 0 new issues), Dependency audit detect step, pr-auto-review. Reviewed automatically by the PR-review agent (single-reviewer mode: opus 4.7). Reply if you need a human review. Additional tasks
The review cascade will automatically re-review after new commits are pushed. |
Automated review — human attention neededThis PR has been through 3 automated review cycles (cap: 3) without converging on an approval-and-merge state. Further automated review has been paused to avoid infinite loops. Please take a look manually, or close this PR if it's no longer needed. Once a human review resolves the situation, remove the Posted by the donpetry-bot PR-review cascade. |
The claude.yml workflow template has been deprecated in favor of dev-lead.yml as the standard workflow for all org repos (ref: PR #301).
All org repos have migrated to dev-lead.yml. This removes the obsolete template from the org-level standards directory and workflow template catalog.
Summary by CodeRabbit