Ruff#52
Conversation
|
I'm not against any of this in principle its a big PR that touches everything. Would be happier if this was split. |
|
I think I have used black on this. Is ruff compatible here? You should absolutely split this PR properly into unrelated commits. The code style changes should be separate from functional changes. Also if you change something like this, we need to make sure that makelove still installs on relevant platforms (Windows 10/11, Linux - recent versions of popular distros). I don't think this should break. Linux is easy to test with docker or VMs at least. And please write down which platforms you tested, so we know what should work. I quite like uv as well, but it is very important to me that existing workflows/installs do not break. |
|
Alright, I put the UV-related changes into #53 and keep this MR open for whether we want pre-commit and/or ruff. Ruff is seen as a drop-in replacement for black+isort+flake but it's not identical. I test everything on Manjaro Linux, but you are right, better testing is required before I start adding more stuff. I wrote this test script + CI: #54 |
Added pyproject.toml, ruff, pre-commit hooks, and run a code style pass (no logical changes) and dropped Python 3.,7 (EOL and it introduces legacy imports). I also recommend using uv but if required
python -m buildwould still work fine.