Skip to content

Ruff#52

Open
Luke100000 wants to merge 2 commits into
pfirsich:masterfrom
Luke100000:ruff
Open

Ruff#52
Luke100000 wants to merge 2 commits into
pfirsich:masterfrom
Luke100000:ruff

Conversation

@Luke100000

Copy link
Copy Markdown
Contributor

Added pyproject.toml, ruff, pre-commit hooks, and run a code style pass (no logical changes) and dropped Python 3.,7 (EOL and it introduces legacy imports). I also recommend using uv but if required python -m build would still work fine.

@Luke100000 Luke100000 mentioned this pull request Apr 25, 2026
@josh-perry

Copy link
Copy Markdown
Collaborator

I'm not against any of this in principle its a big PR that touches everything. Would be happier if this was split.

@pfirsich

Copy link
Copy Markdown
Owner

I think I have used black on this. Is ruff compatible here? You should absolutely split this PR properly into unrelated commits. The code style changes should be separate from functional changes. Also if you change something like this, we need to make sure that makelove still installs on relevant platforms (Windows 10/11, Linux - recent versions of popular distros). I don't think this should break. Linux is easy to test with docker or VMs at least. And please write down which platforms you tested, so we know what should work. I quite like uv as well, but it is very important to me that existing workflows/installs do not break.

@Luke100000

Luke100000 commented Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

Alright, I put the UV-related changes into #53 and keep this MR open for whether we want pre-commit and/or ruff.

Ruff is seen as a drop-in replacement for black+isort+flake but it's not identical.

I test everything on Manjaro Linux, but you are right, better testing is required before I start adding more stuff. I wrote this test script + CI: #54
It tests all targets on all platforms and should have reasonable coverage: https://github.com/Luke100000/makelove/actions/runs/25015037824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants