feat: add rpm to goreleaser build#320
feat: add rpm to goreleaser build#320jason-lynch wants to merge 1 commit intofeat/PLAT-417/systemdfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughRPM packaging configuration added to the build system, including nfpms metadata in goreleaser configuration and new systemd service unit file with associated configuration for managing the pgedge-control-plane process at runtime. Changes
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d41571c to
26c6108
Compare
1e4673e to
9b54d96
Compare
Up to standards ✅🟢 Issues
|
26c6108 to
88440d0
Compare
9b54d96 to
43254b8
Compare
88440d0 to
09d6b52
Compare
43254b8 to
3426d14
Compare
09d6b52 to
2d1d84c
Compare
3426d14 to
12cb3b8
Compare
2d1d84c to
cd7c876
Compare
12cb3b8 to
9095732
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
cd7c876 to
a574a99
Compare
9095732 to
e81f943
Compare
a574a99 to
940cc99
Compare
e81f943 to
e8b57e4
Compare
moizpgedge
left a comment
There was a problem hiding this comment.
Hey, the SELinux part from the ticket is missing no policy file, and no %post/%postun scripts to load/remove it.
Before we add it, is this actually needed?
Good call out! No, this is not needed. I was able to make a code change to make everything work with SELinux enabled and with the default policies. |
Adds an RPM output to our goreleaser build. To create a test build of the RPM, run: ```sh goreleaser-test-release ``` This will create a `dist` directory with release artifacts, including RPMs for both amd64 and arm64. To install and use the RPM: ```sh sudo su - dnf install -y epel-release dnf dnf config-manager --set-enabled crb dnf update -y --allowerasing dnf install -y https://dnf.pgedge.com/reporpm/pgedge-release-latest.noarch.rpm dnf install -y \ pgedge-postgresql18 \ pgedge-spock50_18 \ pgedge-snowflake_18 \ pgedge-lolor_18 \ pgedge-postgresql18-contrib \ pgedge-pgbackrest \ pgedge-python3-psycopg2 \ python3-pip pip install 'patroni[etcd,jsonlogger]==4.1.0' rpm -i <path to rpm file> systemctl start pgedge-control-plane.service ``` From there, you can interact with it as normal, e.g.: ```sh curl http://localhost:3000/v1/cluster/init ``` Keep in mind that the host ID will default to the machine's short hostname. To tail the control-plane logs, do: ``` journalctl -u pgedge-control-plane.service --follow ``` PLAT-459
940cc99 to
490d89c
Compare
e8b57e4 to
7512dc8
Compare
Summary
Adds an RPM output to our goreleaser build.
Testing
To create a test build of the RPM, run:
This will create a
distdirectory with release artifacts, including RPMs for both amd64 and arm64.To install and use the RPM:
sudo su - dnf install -y epel-release dnf dnf config-manager --set-enabled crb dnf update -y --allowerasing dnf install -y https://dnf.pgedge.com/reporpm/pgedge-release-latest.noarch.rpm dnf install -y \ pgedge-postgresql18 \ pgedge-spock50_18 \ pgedge-snowflake_18 \ pgedge-lolor_18 \ pgedge-postgresql18-contrib \ pgedge-pgbackrest \ pgedge-python3-psycopg2 \ python3-pip pip install 'patroni[etcd,jsonlogger]==4.1.0' rpm -i <path to rpm file> systemctl start pgedge-control-plane.serviceFrom there, you can interact with it as normal, e.g.:
Keep in mind that the host ID will default to the machine's short hostname.
To tail the control-plane logs, do:
PLAT-459