Skip to content

Correct the macOS Replace shortcut in Query Tool toolbar docs (#9817)#10033

Merged
asheshv merged 3 commits into
pgadmin-org:masterfrom
dpage:fix-9817-replace-shortcut-doc
Jun 12, 2026
Merged

Correct the macOS Replace shortcut in Query Tool toolbar docs (#9817)#10033
asheshv merged 3 commits into
pgadmin-org:masterfrom
dpage:fix-9817-replace-shortcut-doc

Conversation

@dpage

@dpage dpage commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #9817.

The Query Tool Edit toolbar documentation listed the Replace shortcut as Option + Cmd + F (MAC) / Ctrl + Shift + F (Others). The actual default (registered in web/pgadmin/browser/register_editor_preferences.py: control: True, ctrl_is_meta: True, char: 'r') is Cmd + R (MAC) / Ctrl + R (Others). Updated the doc table accordingly.

Docs-only change; no release note.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Simplified the Query Editing Options toolbar entry for the Replace action: keyboard shortcut consolidated to Cmd/Ctrl + R across platforms, replacing the previous platform-specific shortcut listings.

…admin-org#9817

The Edit toolbar table listed Replace as "Option + Cmd + F (MAC)" /
"Ctrl + Shift + F (Others)", but the default Replace shortcut is
Cmd + R (MAC) / Ctrl + R (Others), per register_editor_preferences.py.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 37e29553-d33d-45d5-98f4-20a1bcd3c93d

📥 Commits

Reviewing files that changed from the base of the PR and between 6716fd7 and 7cb6950.

📒 Files selected for processing (1)
  • docs/en_US/query_tool_toolbar.rst
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/en_US/query_tool_toolbar.rst

Walkthrough

The Query Editing Options toolbar documentation was updated: the Replace shortcut now appears as a unified "Cmd/Ctrl + R" entry instead of separate platform-specific combinations.

Changes

Query Editing Options Toolbar Documentation

Layer / File(s) Summary
Replace command keyboard shortcuts update
docs/en_US/query_tool_toolbar.rst
The Replace action shortcut text in the Query Editing Options table was changed from platform-specific entries to a single Cmd/Ctrl + R entry.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: correcting the macOS Replace shortcut documentation in the Query Tool toolbar.
Linked Issues check ✅ Passed The PR directly addresses issue #9817 by updating the documentation table to show the correct Cmd + R shortcut for macOS instead of the incorrect Option + Cmd + F.
Out of Scope Changes check ✅ Passed All changes are scoped to the documentation file referenced in the issue; no unrelated alterations to code or other documentation files are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pgAdmin 4 documentation for the Query Tool Edit toolbar to reflect the actual default keyboard shortcut for Replace.

Changes:

  • Corrected the documented Replace shortcut to Cmd + R on macOS and Ctrl + R on other platforms.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/en_US/query_tool_toolbar.rst Outdated
@asheshv asheshv merged commit 51e90a9 into pgadmin-org:master Jun 12, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error in Documentation of Query Tool Edit Toolbar about macOS shortcut for Replace

3 participants