Keyboard shortcut improvements: tab switching, editor duplicate-line, dialog Enter/Escape#10067
Open
dpage wants to merge 2 commits into
Open
Keyboard shortcut improvements: tab switching, editor duplicate-line, dialog Enter/Escape#10067dpage wants to merge 2 commits into
dpage wants to merge 2 commits into
Conversation
- Fix the main "tabbed panel forward/backward" shortcut not switching the workspace tabs when keyboard focus is inside a tool (SQL editor, PSQL terminal, ERD or Schema Diff). bindRightPanel now locates the active workspace tab via rc-dock's dock-tab-active class, independent of focus, and restricts cycling to the workspace tab-set. The default shortcut is changed to Ctrl/Cmd+Alt+] / [ so it no longer collides with the Query Tool's inner-panel navigation (Alt+Shift+] / [) and does not emit glyphs on macOS; the bogus key codes (Meta/ContextMenu) are corrected to the bracket key codes. - Add Ctrl/Cmd+Shift+D to duplicate the current line or selection in the SQL editor. - Add Ctrl/Cmd+Enter to save and close object/utility dialogs (including the Query Tool sort/filter dialog), and Escape to close them - dialogs rendered as dockable panels (Properties, Backup, etc.) previously had neither. The Escape handler is scoped to panel dialogs (skips MUI modals, which already close on Escape) and yields to inner controls that handle Escape first. Closes pgadmin-org#7232 Closes pgadmin-org#3834 Closes pgadmin-org#7167 Closes pgadmin-org#5691 Closes pgadmin-org#5196
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughFixes tabbed-panel keyboard navigation when focus is inside nested tools, adds dialog-level Ctrl/Cmd+Enter and Escape handlers for save/close, and adds a Mod-Shift-d CodeMirror binding to duplicate the current line/selection; corresponding docs and release notes updated. ChangesKeyboard Shortcuts Enhancement
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR improves keyboard navigation across pgAdmin’s main workspace tabs, SQL editor (CodeMirror), and SchemaView-based dialogs, and updates documentation/release notes accordingly.
Changes:
- Fixes main tab switching shortcuts so they work even when focus is inside nested tools/iframes, and restricts cycling to the workspace tab-set.
- Adds SQL editor shortcut Mod+Shift+D to duplicate the current line/selection.
- Adds dialog/panel shortcuts: Ctrl/Cmd+Enter to trigger Save, and Escape to Close (for dockable panel dialogs).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| web/pgadmin/static/js/SchemaView/SchemaDialogView.jsx | Add keydown handling for Ctrl/Cmd+Enter (save) and Escape (close) in SchemaView dialogs. |
| web/pgadmin/static/js/components/ReactCodeMirror/components/Editor.jsx | Add CodeMirror keybinding for duplicating current line/selection. |
| web/pgadmin/browser/static/js/keyboard.js | Improve main workspace tab switching by finding the active workspace tab independent of focus and limiting cycling to the active tab-set. |
| web/pgadmin/browser/register_browser_preferences.py | Update default tab-switch shortcuts and correct bracket key codes. |
| docs/en_US/release_notes_9_16.rst | Document the new shortcuts and the tab-switch fix in 9.16 release notes. |
| docs/en_US/keyboard_shortcuts.rst | Update shortcut documentation for new defaults and editor duplicate-line shortcut. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+181
to
+183
| // Ctrl/Cmd+Enter saves and closes the dialog from anywhere within it | ||
| // (issue #7167). onSaveClick is a no-op when there is nothing to save or | ||
| // there is a validation error, so this is safe to call unconditionally. |
| ********* | ||
|
|
||
| | `Issue #6308 <https://github.com/pgadmin-org/pgadmin4/issues/6308>`_ - Fix the infinite loading spinner after an idle database connection is silently dropped, by detecting stale connections and offering a reconnect dialog. | ||
| | `Issue #7232 <https://github.com/pgadmin-org/pgadmin4/issues/7232>`_ - Fix the tabbed panel forward/backward shortcut not switching the main tabs when keyboard focus is inside a tool (SQL editor, PSQL terminal, ERD or Schema Diff). The default shortcut is now Ctrl/Cmd+Alt+] / [ to avoid colliding with the Query Tool's inner-panel navigation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A cluster of keyboard-shortcut improvements across the workspace tabs, the SQL
editor, and dialogs.
Main tab switching (#7232)
The "Tabbed panel forward/backward" shortcut did nothing when keyboard focus
was inside a tool (SQL editor, PSQL terminal, ERD/Schema Diff canvas), because
bindRightPanelresolved the target tab fromdocument.activeElement, whichpointed at the tool's own nested dock tab rather than a workspace tab. It now
locates the active workspace tab via rc-dock's
dock-tab-activeclass(independent of focus) and restricts cycling to the workspace tab-set.
The default was also colliding with the Query Tool's inner-panel navigation
(both were
Alt+Shift+] / [) and emitted typographic glyphs on macOS. Thedefault is changed to Ctrl/Cmd+Alt+] / [ (inner-panel nav keeps
Alt+Shift+] / [, unchanged), and the bogus key codes (Meta / ContextMenu —the latter literally triggered the browser's "display a menu") are corrected to
the real bracket key codes.
SQL editor (#3834)
Add Ctrl/Cmd+Shift+D to duplicate the current line or selection.
Dialogs (#7167, #5691, #5196)
Object/utility dialogs rendered as dockable panels (Properties, Backup, the
Query Tool sort/filter dialog, etc.) gain:
The Escape handler is scoped to panel dialogs (MUI modals already close on
Escape) and yields to inner controls that handle Escape first (e.g. an open
dropdown). This also makes the unsaved-changes confirmation operable from the
keyboard (#5196) without explicit per-button letter shortcuts.
Test plan
Verified interactively in a desktop-mode instance:
Default shortcuts and the new editor shortcut are documented in
keyboard_shortcuts.rst.Closes #7232
Closes #3834
Closes #7167
Closes #5691
Closes #5196
Summary by CodeRabbit
New Features
Bug Fixes
Documentation