Warn before opening a very large JSON value in the data grid (#9868)

[dpage]

Summary

• Opening a very large JSON/JSONB cell in the Query Tool's cell editor parses, pretty-prints and renders the whole document on the main thread. For a pathologically large value (the report uses a jsonb object with 100,000 keys, ~3 MB) this blocks the UI thread and pgAdmin becomes completely unresponsive, with no opportunity for the user to back out.
• This matches the maintainer's assessment on the issue: there should be a warning for large JSON so the user can decide whether to proceed — but currently no such warning fires.
• Fix: gate JsonTextEditor — when the raw cell value exceeds a size threshold (1 MB of characters), render nothing until the user confirms via a warning dialog. If they cancel, the editor closes without doing the expensive parse/render. Small values are unaffected and open immediately, exactly as before. The grid already sets commitOnOutsideClick: false, so the confirm dialog does not dismiss the editor.
• The size-threshold decision is factored into a small, separately unit-tested helper (json_editor_warning.js).

Test plan

• New Jest spec regression/javascript/sqleditor/json_editor_warning.spec.js (5 tests) covering the threshold boundary, custom thresholds, and non-string values — all passing.
• eslint -c .eslintrc.js clean on all changed files.
• Manual: build the reporter's table, View/Edit Data, double-click the wide_data cell — a confirmation dialog appears; Cancel leaves the UI responsive, Continue opens the editor as before. A small jsonb cell opens with no prompt.

Closes #9868

Summary by CodeRabbit

• Bug Fixes

  • Added a confirmation warning before opening very large JSON/JSONB values in the data grid editor to avoid freezing; users can proceed or cancel.

• Documentation

  • Updated 9.16 release notes with the new bug-fix entry.

• Tests

  • Added regression tests covering the large-JSON warning logic and user confirmation flows.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2579b064-b455-4e1d-9840-de18dc776e96

📥 Commits

Reviewing files that changed from the base of the PR and between 4b57462 and b2aa61b.

📒 Files selected for processing (1)

• docs/en_US/release_notes_9_16.rst

---

Walkthrough

Adds a 1MB-size detection helper and wraps the JSON cell editor with a confirmation dialog for large values; refactors the editor into content + wrapper, adds tests validating detection and UI behavior, and updates release notes for issue #9868.

Changes

Large JSON Value Warning Guard

Layer / File(s)	Summary
Large JSON detection helper and predicate logic web/pgadmin/tools/sqleditor/static/js/components/QueryToolDataGrid/json_editor_warning.js, web/regression/javascript/sqleditor/json_editor_warning.spec.js	Defines LARGE_JSON_WARNING_LENGTH (1,048,576) and exports shouldWarnForLargeJSON(value, threshold) that returns true when a string exceeds the threshold. Unit tests cover small/empty strings, exceeding vs. exact threshold, custom thresholds, and non-string inputs; test mocks/stubs included.
JSON editor wrapper with confirmation dialog web/pgadmin/tools/sqleditor/static/js/components/QueryToolDataGrid/Editors.jsx, web/regression/javascript/sqleditor/json_editor_warning.spec.js	Imports shouldWarnForLargeJSON, moves editor UI into JsonTextEditorContent, and replaces exported JsonTextEditor with a wrapper that shows pgAdmin.Browser.notifier.confirm() for large values. On cancel it calls onClose(false); on confirm it renders JsonTextEditorContent. Integration tests verify small/large flows and the regression case (#9868).
Release notes documentation docs/en_US/release_notes_9_16.rst	Adds a Bug fixes bullet for Issue #9868 describing the new warning/confirmation flow when opening very large JSON/JSONB values in the data grid cell editor.

Sequence Diagram

sequenceDiagram
  participant User
  participant JsonTextEditor
  participant shouldWarnForLargeJSON
  participant notifier
  participant JsonTextEditorContent
  
  User->>JsonTextEditor: Open cell editor
  JsonTextEditor->>shouldWarnForLargeJSON: Check value size
  alt Large value exceeds threshold
    shouldWarnForLargeJSON-->>JsonTextEditor: true
    JsonTextEditor->>notifier: Show confirm dialog
    alt User confirms
      notifier-->>JsonTextEditor: Callback triggered
      JsonTextEditor->>JsonTextEditorContent: Render editor
      JsonTextEditorContent-->>User: Display JSON editor
    else User cancels
      notifier-->>JsonTextEditor: Cancel callback
      JsonTextEditor->>User: Call onClose(false)
    end
  else Small value within threshold
    shouldWarnForLargeJSON-->>JsonTextEditor: false
    JsonTextEditor->>JsonTextEditorContent: Render editor immediately
    JsonTextEditorContent-->>User: Display JSON editor
  end

Loading

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and clearly summarizes the primary change: adding a warning before opening very large JSON values in the data grid, with the issue number for traceability.
Linked Issues check	✅ Passed	All code changes directly address issue #9868 requirements: guard mechanism prevents parsing large JSON (>1MB), confirmation dialog prevents unresponsiveness, cancellation closes editor cleanly, and helper module is unit-tested.
Out of Scope Changes check	✅ Passed	All changes are within scope: release notes documentation, JSON editor guard logic, warning threshold module, regression tests, and no unrelated modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Adds a size-based guard to the Query Tool data grid JSON cell editor to avoid UI hangs when opening very large JSON/JSONB values (issue #9868), prompting the user before doing expensive parse/pretty-print/render work on the main thread.

Changes:

• Introduces shouldWarnForLargeJSON + LARGE_JSON_WARNING_LENGTH helper for determining when to warn.
• Wraps JsonTextEditor with a confirmation gate for large raw JSON strings.
• Adds Jest coverage for the helper and updates v9.16 release notes.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
web/regression/javascript/sqleditor/json_editor_warning.spec.js	Adds Jest tests for the size-threshold warning helper.
web/pgadmin/tools/sqleditor/static/js/components/QueryToolDataGrid/json_editor_warning.js	Implements threshold constant + helper predicate for large JSON warning.
web/pgadmin/tools/sqleditor/static/js/components/QueryToolDataGrid/Editors.jsx	Gates the JSON cell editor behind a confirm dialog for large values.
docs/en_US/release_notes_9_16.rst	Documents the fix for issue #9868 in release notes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.