fix: delegate NOTICE generation to SDK for uv-managed apps#223
Merged
Conversation
For apps using the SOAR SDK (detected by presence of uv.lock), delegate NOTICE generation to `uv run soarapps manifests create-notice`, which is available in splunk-soar-sdk >= 3.20.0. If the SDK is missing or too old, raise a clear error prompting the user to upgrade. Removes the broken pyproject.toml-based dependency parsing path that produced empty NOTICE files. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sodle-splunk
force-pushed
the
fix/generate-notice-sdk-delegation
branch
from
fa15988 to
f862679
Compare
phantom-jacob
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv.lock), NOTICE generation is now delegated touv run soarapps manifests create-notice, available insplunk-soar-sdk >= 3.20.0RuntimeErrorprompting the user to upgradepyproject.toml-based dependency parsing path that silently produced empty NOTICE files (raw PEP 508 specifiers likerequests>=2.28.0were passed directly topip-licenses, which couldn't resolve them)uv.lockcontinue using the existingrequirements.txtflow unchanged🤖 Generated with Claude Code