fix: isolate container pip from host pythonpath in package-app-dependencies hook#224
Merged
Conversation
pythonpath in package-app-dependencies hook
3906170 to
3bc756a
Compare
3bc756a to
53691ba
Compare
mnordby-splunk
approved these changes
May 4, 2026
Contributor
|
Confirmed this resolved the issue here: https://github.com/splunk-soar-connectors/awss3/actions/runs/25342919719/job/74304540009?pr=24 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix package-app-dependencies failing in CI due to host pre-commit PYTHONPATH leaking into container pip. The pre-commit env is now created on Python 3.13 with newer pip, and container pip3.9 was importing that
host pip, causing a dataclass(..., slots=True) crash. This change isolates the pre-commit path for local_hooks imports only and clears it for container pip commands.
Tested here by creating temporary PR with this branch as ref splunk-soar-connectors/salesforce#24
Run verifying fix in repo with wheels in it - https://github.com/splunk-soar-connectors/googleworkspacefordrive/pull/35/changes (no more
TypeError: dataclass() got an unexpected keyword argument 'slots'errorFailure seen in multiple repos -
https://github.com/splunk-soar-connectors/salesforce/actions/runs/25104646229/job/73562620180?pr=22