Update gcloud version#1
Conversation
WalkthroughThe Dockerfile build stage base image is updated from Google Cloud CLI version 399.0.0 to 568.0.0, using Alpine Linux. The build stage alias remains unchanged. ChangesBuild stage base image update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/Dockerfile (1)
1-8: ⚡ Quick winConsider explicitly setting the non-root
USERin this Dockerfile stage.The base image
gcr.io/google.com/cloudsdktool/google-cloud-cli:568.0.0-alpinealready defaults to the non-root user "cloudsdk", so runtime will inherit that. However, since this is a multi-stage build, explicitly settingUSER cloudsdkafter the install/cleanup steps clarifies the runtime user and avoids ambiguity if subsequent stages reset it.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/Dockerfile` around lines 1 - 8, The Dockerfile's build stage currently uses the google-cloud-cli Alpine image but doesn't explicitly set the non-root user; after the install/cleanup RUN block that installs kubectl and gke-gcloud-auth-plugin (the RUN that also removes python caches), add an explicit USER cloudsdk declaration so the build stage (and any subsequent stages that inherit it) clearly runs as the non-root "cloudsdk" user rather than relying on the base image default.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/Dockerfile`:
- Around line 1-8: The Dockerfile's build stage currently uses the
google-cloud-cli Alpine image but doesn't explicitly set the non-root user;
after the install/cleanup RUN block that installs kubectl and
gke-gcloud-auth-plugin (the RUN that also removes python caches), add an
explicit USER cloudsdk declaration so the build stage (and any subsequent stages
that inherit it) clearly runs as the non-root "cloudsdk" user rather than
relying on the base image default.
Summary by CodeRabbit