Skip to content

feat: gate linux installer on GLIBC version and disable auto-update f…#718

Merged
abose merged 1 commit into
mainfrom
feat/glibc-guard-disable-autoupdate
May 27, 2026
Merged

feat: gate linux installer on GLIBC version and disable auto-update f…#718
abose merged 1 commit into
mainfrom
feat/glibc-guard-disable-autoupdate

Conversation

@charlypa
Copy link
Copy Markdown
Contributor

…or old systems

The new AppImage is built on ubuntu-22.04 (GLIBC 2.35) and cannot run on older systems like Ubuntu 20.04 (GLIBC 2.31). When the installer detects an incompatible GLIBC, it sets "autoUpdate": false in phcode.json to prevent the old version from repeatedly attempting an upgrade that will never succeed.

Tested on ubuntu20 (2.31, refused), ubuntu26 (2.43, passed), fedora-44 (2.43, passed).

What kind of change does this PR introduce?

  • Bugfix - fixes issues- give issue github url/details here.
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Screenshots or Gifs of the change

  1. Any visual or workflow changes must come with a gif or screenshot.
  2. Gif screen recordings help more if present. You can use one of the below free screen recorders:
    1. windows gif recorder- https://www.screentogif.com/
    2. mac gif recorder- https://apps.apple.com/au/app/giphy-capture-the-gif-maker/id668208984?mt=12
    3. linux gif recorder- https://github.com/phw/peek

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Tests done

  • Describe unit tests done
  • Describe integration tests done
  • Describe manual tests done

Checklist

  • When resolving issues, reference those issue URLs in description.
  • Propose a changelog if this pull request has any customer facing impact.
  • I have added a convincing reason for adding this feature, if necessary.

Other information

pull request guidelines:

  • It's OK to have multiple small commits as you work on the PR - we will let GitHub automatically squash it before merging.
  • If adding new feature:, Provide convincing reason to add this feature. Ideally you should open a suggestion issue first and have it greenlighted before working on it.
  • If fixing a bug:Provide detailed description of the bug in the PR, or link to an issue that does.
  • Provide screenshots or gifs of the changes whenever possible.

…or old systems

The new AppImage is built on ubuntu-22.04 (GLIBC 2.35) and cannot run on
older systems like Ubuntu 20.04 (GLIBC 2.31). When the installer detects
an incompatible GLIBC, it sets "autoUpdate": false in phcode.json to
prevent the old version from repeatedly attempting an upgrade that will
never succeed.

Tested on ubuntu20 (2.31, refused), ubuntu26 (2.43, passed),
fedora-44 (2.43, passed).
@sonarqubecloud
Copy link
Copy Markdown

@abose abose merged commit 3480658 into main May 27, 2026
2 of 6 checks passed
@abose abose deleted the feat/glibc-guard-disable-autoupdate branch May 27, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants