feat: gate linux installer on GLIBC version and disable auto-update f…#718
Merged
Conversation
…or old systems The new AppImage is built on ubuntu-22.04 (GLIBC 2.35) and cannot run on older systems like Ubuntu 20.04 (GLIBC 2.31). When the installer detects an incompatible GLIBC, it sets "autoUpdate": false in phcode.json to prevent the old version from repeatedly attempting an upgrade that will never succeed. Tested on ubuntu20 (2.31, refused), ubuntu26 (2.43, passed), fedora-44 (2.43, passed).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



…or old systems
The new AppImage is built on ubuntu-22.04 (GLIBC 2.35) and cannot run on older systems like Ubuntu 20.04 (GLIBC 2.31). When the installer detects an incompatible GLIBC, it sets "autoUpdate": false in phcode.json to prevent the old version from repeatedly attempting an upgrade that will never succeed.
Tested on ubuntu20 (2.31, refused), ubuntu26 (2.43, passed), fedora-44 (2.43, passed).
What kind of change does this PR introduce?
Screenshots or Gifs of the change
Does this PR introduce a breaking change?
Tests done
Checklist
Other information
pull request guidelines: