Skip to content

feat: promote electron installer to prod stage #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 2 commits into from
May 27, 2026
Merged

feat: promote electron installer to prod stage #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c77134
feat: promote electron installer to prod stage
abose May 27, 2026
ca9c98c
fix: download before uninstall and point prod installer to stable upd…
abose May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docs/linux/installer-latest-experimental-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@
print_keyring_hint_if_locked
}

downloadAndInstall() {
downloadAndVerifyDeps() {

Check warning on line 459 in docs/linux/installer-latest-experimental-build.sh

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Function 'downloadAndVerifyDeps' should be named in snake case. 


See more on https://sonarcloud.io/project/issues?id=phcode-dev_phoenix-desktop&issues=AZ5p2gcnU1aRbXyLU3r6&open=AZ5p2gcnU1aRbXyLU3r6&pullRequest=719
echo "Using temporary directory $TMP_DIR for processing"
downloadLatestReleaseInfo > /dev/null
check_architecture
Expand Down Expand Up @@ -549,16 +549,16 @@
echo -e "${YELLOW}Phoenix Code appears to be already installed.${RESET}"
if [ ! -t 0 ]; then
echo -e "${GREEN}Reinstalling Phoenix Code...${RESET}"
downloadAndVerifyDeps
uninstall
downloadAndInstall
copyFilesToDestination
else
read -r -p "Would you like to reinstall it? (y/N): " response
case "$response" in
[Yy]* )
echo -e "${GREEN}Reinstalling Phoenix Code...${RESET}"
downloadAndVerifyDeps
uninstall
downloadAndInstall
copyFilesToDestination
;;
* )
Expand All @@ -568,7 +568,7 @@
esac
fi
else
downloadAndInstall
downloadAndVerifyDeps
copyFilesToDestination
fi
}
Expand Down Expand Up @@ -597,7 +597,7 @@

if [ -n "$latest_version" ] && [ "$(printf '%s\n' "$latest_version" "$current_version" | sort -V | tail -n1)" = "$latest_version" ] && [ "$latest_version" != "$current_version" ]; then
echo -e "${YELLOW}A newer version of Phoenix Code is available. Proceeding with the upgrade...${RESET}"
downloadAndInstall
downloadAndVerifyDeps
uninstall
copyFilesToDestination
echo -e "${GREEN}Upgrade completed successfully. Phoenix Code has been updated to the latest version.${RESET}"
Expand Down
Loading
Loading