Conversation
…racted The adm-zip extractEntryTo call in downloadNodeBinary.js did not pass the overwrite flag, causing postinstall to fail with "Target file already exists" on repeat runs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
GDI APIs (GetClientRect, PrintWindow, GetDIBits) operate in physical pixels for DPI-aware processes, but the JS caller sends the capture rect in CSS pixels (scaled only by the webview zoom factor, not the OS DPI). At Windows display scaling >100%, this produced screenshots that were both shifted and undersized. Multiply the incoming rect by window.scale_factor() (the OS DPI scale, e.g. 1.25 at 125% scaling) before clamping to the physical client area. macOS is unaffected because WKSnapshotConfiguration.setRect takes view points, which map 1:1 to CSS pixels. Electron (Linux) is unaffected because capturePage already accepts CSS-pixel rects.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GDI APIs (GetClientRect, PrintWindow, GetDIBits) operate in physical
pixels for DPI-aware processes, but the JS caller sends the capture
rect in CSS pixels (scaled only by the webview zoom factor, not the
OS DPI). At Windows display scaling >100%, this produced screenshots
that were both shifted and undersized.
Multiply the incoming rect by window.scale_factor() (the OS DPI scale,
e.g. 1.25 at 125% scaling) before clamping to the physical client area.
macOS is unaffected because WKSnapshotConfiguration.setRect takes view
points, which map 1:1 to CSS pixels. Electron (Linux) is unaffected
because capturePage already accepts CSS-pixel rects.