feat!: remove deprecated preventSigmaIncrease option#989
Merged
Conversation
The preventSigmaIncrease option was renamed to limitSigma long ago and has been carrying a "this will go away someday" comment ever since. Drop the alias and ship as part of the v5 major.
|
coverage: 100.0%. remained the same — claude/inspiring-fermi-JPFBT into main |
philihp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preventSigmaIncreaseoption (replaced bylimitSigma). The old name was kept as an alias with a// this will go away somedaynote since before this repo's visible git history — v5 is the right time to drop it.limitSigma, and removes one test that was an exact duplicate of the equivalentlimitSigmatest.Test plan
npm test— all 207 tests passGenerated by Claude Code