refactor(models): rename sigSqToCiq to qEta to match paper notation#990
Merged
Conversation
Per Weng & Lin (2011) §3.1.1, the quantity iSigmaSq/ciq corresponds to η_q in the paper. Renaming the local variable across the Bradley-Terry and Thurstone-Mosteller models for easier cross-reference with the paper. No behaviour change. Addresses #203.
|
coverage: 100.0%. remained the same — claude/focused-hopper-AGlhP into main |
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sigSqToCiqvariable toqEtaacross the Bradley-Terry and Thurstone-Mosteller models so it matches η_q from Weng & Lin (2011) §3.1.1.Addresses #203 (the specific example called out in the issue body).
Test plan
npm test— all 208 tests passqEtavs e.g.etaQ) before mergingGenerated by Claude Code