Third-party manual, doc-base side - #324
Merged
Merged
Conversation
Member
Author
|
Comments and reviews wellcome. Build breakage is expected, as manual.xml still does not exist on doc-en. |
jordikroon
reviewed
Jul 21, 2026
Member
Author
|
Tomorrow is the big day. With this PR, doc-base becores almost independent of main manual |
Member
Author
|
Merged. No differences detected on XML body so far. I will do some more tests, on all languages, to be sure. Next in line, DOCTYPE minimization, XML trim and possibly adding a warning on GH CI builds about invalid results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the doc-base side of php/doc-en#5682 , for the splitting of third-party manuals from the main manual, with the minimal conventions possible. I took the path of also minimizing any XML output differences. In fact, the only output change occurs in the DOCTYPE node, the XML is identical. Also, the code is already prepared for any disappearance of actual DTD entity files.
As this is a big change, I plan to leave this open for almost two weeks.
The planned merge order is doc-en 5682 on July 30, and this in July 31. In the meantime, preparing for the actual disappearance of DTD entity files.