Skip to content

docs: improve closure variable inheritance examples#4826

Open
joshtrichards wants to merge 1 commit into
php:masterfrom
joshtrichards:patch-1
Open

docs: improve closure variable inheritance examples#4826
joshtrichards wants to merge 1 commit into
php:masterfrom
joshtrichards:patch-1

Conversation

@joshtrichards
Copy link
Copy Markdown
Contributor

  • Additional comments
  • Clarify existing comments
  • Format comments consistently
  • Modernize example output
  • More distinct return value example

@kamil-tekiela
Copy link
Copy Markdown
Member

I think this are too many comments now. The output is already shown below the example. If it's not obvious which line is from which call then maybe the example should be split into multiple examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants