Update preg-match-all.xml#4832
Closed
php4fan wants to merge 1 commit into
Closed
Conversation
Contributor
Contributor
|
@Crell Not for me to decide. I'd recommend having a look at the complete param info. Might be that re-ordering the info and/or adding some emphasis in select places would help. Not sure duplicating info is the best way as it makes maintenance of the docs harder. |
Member
|
I think duplication isn't useful. However, a different PR can still solve the issue by moving the sentence to the top of the param description or highlighting it in some other way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4831