-
Notifications
You must be signed in to change notification settings - Fork 883
Update screens for output that changed with PHP itself #5720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KentarouTakeda
wants to merge
13
commits into
php:master
Choose a base branch
from
KentarouTakeda:fix-screen-behaviour-changes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6d44e89
Update screens for operator semantics that changed
KentarouTakeda ff05449
Update screens for diagnostics that changed
KentarouTakeda 2ba57e5
Reflect a tentative return type instead of a built-in function
KentarouTakeda 03ad3ca
Regenerate the ReflectionClass::__toString() screen
KentarouTakeda d4e0fc3
Update screens for how class names are printed
KentarouTakeda ac7eb8d
Update the mb_detect_encoding() screen for its PHP 8.3 behaviour
KentarouTakeda 35185c4
Split the mb_detect_encoding() screens at PHP 8.3
KentarouTakeda a057c25
Use simpara for the getReturnType() note
KentarouTakeda 21008d6
Merge the . precedence examples and split them at PHP 8.0
KentarouTakeda 83171fa
Note the instanceof constant error removed at PHP 7.3
KentarouTakeda 4dcf024
Split the foreach list() screens at PHP 8.0
KentarouTakeda 1b0d325
Split the __set_state() screens at PHP 8.2
KentarouTakeda 75d9208
Keep Run code off the mb_detect_encoding() PHP 8.2 screen
KentarouTakeda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but we need to retain the error message. Perhaps split it into two outputs per version? Or just add a code comment on
var_dump(FALSE instanceof stdClass);saying it would throw with this error message?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took the code comment. A split would mislead here: prior to 7.3 this is a compile-time error, so 7.2 prints the fatal line and nothing else — none of the three
bool(false)above it ever run. The screen that was here, three bools followed by the fatal error, was never any version's output.That's why the comment says "so nothing above ran". The 7.3 boundary itself is already covered by the example directly below, which uses
&example.outputs.73;.