Open
Conversation
Member
Author
|
Just to note that the current implementation is just an API draft that is not really tested. It's also does not handle the buffered procession and no current filter implements it. Also it will need proper tests. |
bukka
force-pushed
the
stream_filter_seeking
branch
from
e78adee to
41aee5a
Compare
Member
Author
|
This is now ready for review. |
Member
Author
|
This is just a heads up that I plan to merge it tomorrow unless someone wants more time for review or finds anything that needs to be addressed. Of course, I'm happy to address any potentially issue even if found after merging. I just don't want to wait for review forever as this needs to get merged (part of my stream work)... |
bukka
force-pushed
the
stream_filter_seeking
branch
from
73bcbd9 to
f6f6152
Compare
Member
Author
|
@ndossche Thanks a lot for the review. Hopefully all comments addressed. |
bukka
force-pushed
the
stream_filter_seeking
branch
from
4d5362e to
77392ee
Compare
…ilters Currently filter seeking does not work correctly for most streams. The idea is to extend API to allow seeking for some streams. There are couple of cases: - filter is always seekable - e.g. string.rot13, string.toupper, string.tolower - filter is seekable only when sought to start or when it re-run the data from the start (it means when there is some data buffered) - this is for pretty much all other filters that keep some state. - user filters are seekable by default for BC reason but if new seek method is implemented, then it is called and based on the bool result the seeking either fails or succeed.
bukka
force-pushed
the
stream_filter_seeking
branch
from
77392ee to
48a7181
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently filter seeking does not work correctly for most streams. The idea is to extend API to allow seeking for some streams. There are couple of cases:
string.rot13,string.toupper,string.tolowerThe seeking to zero is implemented by resetting the internal state.
Fixes https://bugs.php.net/bug.php?id=49874