Skip to content

ext/sqlite3: fix wrong pointer types passed to the free list comparator. #21483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devnexen wants to merge 4 commits into from
+5 −5
Closed

ext/sqlite3: fix wrong pointer types passed to the free list comparator. #21483

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18d287e
ext/sqlite3: fix wrong pointer types passed to the free list comparator.
devnexen Mar 21, 2026
c66dde1
ext/sqlite3: compare php_sqlite3_stmt pointers consistently.
devnexen Mar 21, 2026
0e0368d
Add test for the free list comparator fix.
devnexen Apr 6, 2026
b4d4987
remove pointless test
devnexen Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/sqlite3/sqlite3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1415,7 +1415,7 @@ PHP_METHOD(SQLite3Stmt, close)

SQLITE3_CHECK_INITIALIZED(stmt_obj->db_obj, stmt_obj->initialised, SQLite3);

zend_llist_del_element(&(stmt_obj->db_obj->free_list), stmt_obj, (int (*)(void *, void *)) php_sqlite3_compare_stmt_free);
zend_llist_del_element(&(stmt_obj->db_obj->free_list), stmt_obj->stmt, (int (*)(void *, void *)) php_sqlite3_compare_stmt_free);

RETURN_TRUE;
}
Expand Down Expand Up @@ -2145,7 +2145,7 @@ PHP_METHOD(SQLite3Result, finalize)

/* We need to finalize an internal statement */
if (!result_obj->is_prepared_statement) {
zend_llist_del_element(&(result_obj->db_obj->free_list), &result_obj->stmt_obj,
zend_llist_del_element(&(result_obj->db_obj->free_list), result_obj->stmt_obj->stmt,
(int (*)(void *, void *)) php_sqlite3_compare_stmt_free);
} else {
sqlite3_reset(result_obj->stmt_obj->stmt);
Expand Down
Loading