[PFA 4/n] Optimize constant pre-bound arguments - #22829
Merged
Merged
Conversation
arnaud-lb
marked this pull request as ready for review
July 20, 2026 15:20
arnaud-lb
force-pushed
the
partials-const-arg-opt
branch
from
July 22, 2026 08:06
9d58c43 to
b362aca
Compare
TimWolla
reviewed
Jul 24, 2026
Pre-bound arguments are bound to the generated closure's lexical vars:
```
function f($a, $b) {}
$f = f(1, ?);
// Generates:
$tmp = 1;
$f = function ($b) use ($tmp) {
return f($tmp, $b);
};
```
Detect which pre-bound arguments are constant and burn them into the generated
closure instead:
```
function f($a, $b) {}
$f = f(1, ?);
// Generates:
$f = function ($b) {
return f(1, $b);
};
```
arnaud-lb
force-pushed
the
partials-const-arg-opt
branch
from
July 27, 2026 16:00
5b670e7 to
62324a8
Compare
TimWolla
reviewed
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The branch includes GH-22785, but only the commit "PFA: Optimize constant pre-bound arguments" is relevant for this PR. (Edit: branch was rebased and doesn't include GH-22785 anymore.)
Currently PFA pre-bound arguments are bound to the generated closure's lexical vars:
In this PR we detect which pre-bound arguments are constant and burn them into the generated closure instead:
This reduces the overhead during both instantiation and invocation of PFAs.