streams: php_stream_copy_to_stream_ex() drops progress notifications. - #22863
Closed
devnexen wants to merge 3 commits into
Closed
streams: php_stream_copy_to_stream_ex() drops progress notifications.#22863devnexen wants to merge 3 commits into
devnexen wants to merge 3 commits into
Conversation
Fix php#22841 The fd-level copy fast path hands the transfer to the kernel, so the bytes bypassed php_sockop_read() and neither the progress increments nor the completion event were emitted. Skip the fast path when either stream carries a context notifier.
alecpl
reviewed
Jul 23, 2026
| } | ||
|
|
||
|
|
||
| static bool php_stream_copy_context(php_stream *stream) |
There was a problem hiding this comment.
Shouldn't this be better named php_stream_has_notifier()?
Member
Author
There was a problem hiding this comment.
sure I do not mind changing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #22841
The fd-level copy fast path hands the transfer to the kernel, so the bytes bypassed php_sockop_read() and neither the progress increments nor the completion event were emitted. Skip the fast path when either stream carries a context notifier.