Remove param argument from php_verror

[NattyNarwhal]

Update tests and UPGRADING.INTERNALS.

Note there is some impact to extensions if they call this; however, it's usually in a centralized wrapper function which is easy to update. In my quick skim of external extensions, apcu is the only maintained one that'll need an update.

Also note that php_verror is a bit weirdly named. It should probably be called something like php_docref_verror, since php_error_docref the vararg wrapper around it (now that 1/2 are gone); let me know if this is something worth pursuing. There is php_error, which is just an alias for zend_error, which doesn't take a docref, nor does it have the function and args prefix that php_verror has. It should be used for engine stuff, but I think there are a few places where it's called from places where php_error_docref should be used instead in extensions. I can take a look at that too.

[Girgias]

I think removing php_error and recommend the docref version instead makes sense.

[NattyNarwhal]

I think removing php_error and recommend the docref version instead makes sense.

Just to be clear, just the alias php_error? Since zend_error is used pretty commonly throughout the engine has different output than php_verror. (Though there's also some zend_error calls in extensions too, I realize...)

[Girgias]

I think removing php_error and recommend the docref version instead makes sense.

Just to be clear, just the alias php_error? Since zend_error is used pretty commonly throughout the engine has different output than php_verror. (Though there's also some zend_error calls in extensions too, I realize...)

Yeah just the alias, I think there is a way to set php_docref to be used within "zend" as a lot of utility functions that are used by zend are actually defined in main/ but that's definitely something else.

[NattyNarwhal]

Cool, I'll try to tackle php_error/zend_error cleanup in a separate PR.