support for generic params on alias types#297
Open
shmax wants to merge 3 commits intophpstan:2.3.xfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Generic Type Parameters to Type Aliases
This PR adds support for generic type parameters on
@phpstan-typealiases, including multiline syntax support.See: phpstan/phpstan-src#5378
Features
Generic Type Parameters on Type Aliases
Type aliases can now declare template parameters directly on the alias definition:
Multiline Syntax Support
Complex generic type aliases can be formatted across multiple lines for improved readability:
Use Cases
This enables more flexible and reusable type definitions:
Technical Details
AST Changes
TypeAliasTagValueNodenow includes a$templateTypesproperty containing an array ofTemplateTagValueNode[]<...>syntax immediately after the alias nameof), defaults (=), and multiple parametersParser Behavior
The parser now:
<...>parseTemplateTagValue()methodPrinter Support
The
Printerclass correctly outputs generic type aliases with template parameters in both regular and format-preserving modes.Testing
Added comprehensive test coverage:
T of object)T = string)All existing tests pass, ensuring backward compatibility.
Examples
Before (workaround)
After (direct declaration)
This aligns PHPDoc type alias syntax more closely with TypeScript, Java, and other languages that support generic type declarations.