Sync ObjectRepository stub types with Doctrine#767
Merged
Conversation
herndlm
force-pushed
the
sync-object-repository
branch
from
52cdec2 to
0a75162
Compare
herndlm
force-pushed
the
sync-object-repository
branch
from
0a75162 to
3b43e2f
Compare
Contributor
Author
|
saw those param changes and copied them over too. should I revert them to avoid potential annoying new reported issues popping up? 🤔 |
VincentLanglet
approved these changes
Jun 10, 2026
Contributor
I think it's ok to have the same than original class, like you did |
staabm
approved these changes
Jun 10, 2026
Contributor
Author
|
hi guys, thx for merging this so fast, but the criteria type change was a bug/mistake, I get a huge amount of false positives now. let me quickly fix that.. sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: phpstan/phpstan#14802
See https://github.com/doctrine/persistence/blob/4.2.x/src/ObjectRepository.php
no clue if this file is even being needed still, maybe for older versions of Doctrine?
looks like they changed it to a list just recently, see doctrine/persistence@d2ab8e3
there's also open #762 which might be trying to fix the same thing