Support stringNode in Config component#459
Open
emodric wants to merge 1 commit into
Open
Conversation
staabm
reviewed
Nov 11, 2025
| private const PROTOTYPE_METHODS = [ | ||
| 'arrayPrototype', | ||
| 'scalarPrototype', | ||
| 'stringPrototype', |
Contributor
There was a problem hiding this comment.
Indent seems off (also in other files)
Contributor
Author
|
@staabm I've fixed the indentation issue and I've tried adding a test, but it turns out that tests do not support Symfony 7. I'll leave this up once this lib gets up to Symfony 7. |
Contributor
|
In Symfony 7.4, we have conditional return types in Symfony itself that should make this return type extension useless. It might be better to disable it for new Symfony versions to benefit from the upstream work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony 7.2 added
>stringNode()method toNodeBuilder.