Skip to content

Work around for https://github.com/bazelbuild/rules_cc/issues/558#1899

Merged
phst merged 1 commit into
masterfrom
unbreak
Jun 9, 2026
Merged

Work around for https://github.com/bazelbuild/rules_cc/issues/558#1899
phst merged 1 commit into
masterfrom
unbreak

Conversation

@phst

@phst phst commented Jun 9, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a workaround in .bazelrc for a Windows rules_cc issue by setting linker flags. The reviewer suggests using the hyphen prefix (-WX:NO) instead of the slash prefix (/WX:NO) to prevent potential path translation issues in certain Windows environments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread .bazelrc Outdated
@phst phst force-pushed the unbreak branch 2 times, most recently from cd9d398 to 01fc516 Compare June 9, 2026 17:21
@phst phst merged commit 01d0e6a into master Jun 9, 2026
18 checks passed
@phst phst deleted the unbreak branch June 9, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant