-
Notifications
You must be signed in to change notification settings - Fork 52
Improving imagemagick security #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+60
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE policymap [ | ||
| <!ELEMENT policymap (policy)*> | ||
| <!ATTLIST policymap xmlns CDATA #FIXED ''> | ||
| <!ELEMENT policy EMPTY> | ||
| <!ATTLIST policy xmlns CDATA #FIXED '' domain NMTOKEN #REQUIRED | ||
| name NMTOKEN #IMPLIED pattern CDATA #IMPLIED rights NMTOKEN #IMPLIED | ||
| stealth NMTOKEN #IMPLIED value CDATA #IMPLIED> | ||
| ]> | ||
| <!-- | ||
| Hardened ImageMagick policy for Pimcore. | ||
|
|
||
| Pimcore rasterises uploaded, untrusted SVG assets through ImageMagick (via the | ||
| Imagick PHP extension). ImageMagick's SVG renderer follows <image xlink:href="..."> | ||
| references to other "coders" / pseudo-protocols. | ||
|
|
||
| This policy denies the coders those hrefs invoke. SVG itself stays enabled, so | ||
| legitimate SVG thumbnails still render, but any href that points at a file-reading, | ||
| text-rendering, scripting, or network coder is refused with "not authorized". | ||
|
|
||
| NOTE (scope): This is an ImageMagick-level control. It cannot inspect SVG XML and | ||
| therefore does NOT literally strip <script> tags or href attributes. Removing | ||
| <script>/href from SVG (the stored-XSS concern, and defence-in-depth for the above) | ||
| is an application-layer job for an SVG sanitiser in pimcore/pimcore, not this image. | ||
|
|
||
| Coders deliberately LEFT ENABLED so Pimcore previews keep working: | ||
| * SVG / MSVG / MVG - SVG thumbnail rasterisation (internal renderer needs MVG) | ||
| * PDF / PS / EPS / XPS - document thumbnails via the Ghostscript delegate | ||
| * image/video coders - normal asset processing | ||
| --> | ||
| <policymap> | ||
| <!-- Scripting coder that can read files and execute read/write steps (RCE vector). --> | ||
| <policy domain="coder" rights="none" pattern="MSL" /> | ||
|
|
||
| <!-- Text/label coders that read a local file or embed arbitrary content. --> | ||
| <policy domain="coder" rights="none" pattern="TEXT" /> | ||
| <policy domain="coder" rights="none" pattern="LABEL" /> | ||
| <policy domain="coder" rights="none" pattern="CAPTION" /> | ||
| <policy domain="coder" rights="none" pattern="INFO" /> | ||
|
|
||
| <!-- Network coders reachable via href (remote include / SSRF). --> | ||
| <policy domain="coder" rights="none" pattern="URL" /> | ||
| <policy domain="coder" rights="none" pattern="HTTP" /> | ||
| <policy domain="coder" rights="none" pattern="HTTPS" /> | ||
| <policy domain="coder" rights="none" pattern="FTP" /> | ||
|
|
||
| <!-- Miscellaneous coders with no legitimate use in a server-side pipeline. --> | ||
| <policy domain="coder" rights="none" pattern="EPHEMERAL" /> | ||
| <policy domain="coder" rights="none" pattern="SHOW" /> | ||
| <policy domain="coder" rights="none" pattern="WIN" /> | ||
| <policy domain="coder" rights="none" pattern="PLT" /> | ||
|
|
||
| <!-- Refuse indirect reads via the @filename syntax (e.g. @/etc/passwd). --> | ||
| <policy domain="path" rights="none" pattern="@*" /> | ||
| </policymap> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.