Skip to content

Add .devcontainer/devcontainer-lock.json, resolve oxfmt issues with vscode#2468

Open
Spitfire1900 wants to merge 8 commits into
pingdotgg:mainfrom
Spitfire1900:add-.devcontainer/devcontainer-lock.json
Open

Add .devcontainer/devcontainer-lock.json, resolve oxfmt issues with vscode#2468
Spitfire1900 wants to merge 8 commits into
pingdotgg:mainfrom
Spitfire1900:add-.devcontainer/devcontainer-lock.json

Conversation

@Spitfire1900
Copy link
Copy Markdown
Contributor

@Spitfire1900 Spitfire1900 commented May 2, 2026

What Changed

Add .devcontainer/devcontainer-lock.json
Resolve oxfmt issues with vscode - oxc-project/oxc-vscode#224

Why

Beginning with VSCode 1.118 fresh builds of devcontainers will create a .devcontainer/devcontainer-lock.json file and VSCode will honor the devcontainer-lock.json file if it exists.

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • [N/A] I included before/after screenshots for any UI changes
  • [N/A] I included a video for animation/interaction changes

Note

Low Risk
Low risk: changes are limited to devcontainer reproducibility and formatter dependency updates, with no runtime/business logic impact.

Overview
Adds .devcontainer/devcontainer-lock.json so VS Code devcontainer builds can pin feature versions/digests for more reproducible environments.

Updates .oxfmtrc.json to format the new lockfile consistently (no trailing commas and no final newline), and bumps the formatter dependency oxfmt from ^0.40.0 to ^0.49.0 (with corresponding bun.lock updates to the new platform bindings).

Reviewed by Cursor Bugbot for commit e87c13e. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add devcontainer lock file and bump oxfmt to 0.49.0

  • Adds devcontainer-lock.json pinning the bun, git, node, and python features to specific versions with resolved image digests and integrity hashes.
  • Bumps oxfmt from 0.40.0 to 0.49.0 in package.json, updating all platform-specific bindings in the lockfile.
  • Adds a formatting override in .oxfmtrc.json to disable trailing commas and final newline for the lock file.

Macroscope summarized e87c13e.

Beginning with VSCode 1.118 fresh builds of devcontainers will create a .devcontainer/devcontainer-lock.json file
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 2, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 7b62db03-7e89-4af2-a994-130bdf2b5c43

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels May 2, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes May 2, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 2, 2026

Approvability

Verdict: Approved

Development tooling changes only: adds devcontainer lockfile, formatter configuration for that file, and updates the oxfmt formatter dependency. No runtime behavior impact.

You can customize Macroscope's approvability policy. Learn more.

@macroscopeapp macroscopeapp Bot dismissed their stale review May 2, 2026 13:19

Dismissing prior approval to re-evaluate 964f923

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels May 2, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes May 2, 2026
@macroscopeapp macroscopeapp Bot dismissed their stale review May 2, 2026 13:27

Dismissing prior approval to re-evaluate b735103

Comment thread .devcontainer/devcontainer.json Outdated
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes May 2, 2026
@macroscopeapp macroscopeapp Bot dismissed their stale review May 2, 2026 13:32

Dismissing prior approval to re-evaluate 8b34e4a

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes May 2, 2026
@macroscopeapp macroscopeapp Bot dismissed their stale review May 13, 2026 16:35

Dismissing prior approval to re-evaluate 296c6fa

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). and removed size:M 30-99 changed lines (additions + deletions). labels May 13, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 296c6fa. Configure here.

Comment thread bun.lock Outdated
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:L 100-499 changed lines (additions + deletions). labels May 13, 2026
@Spitfire1900 Spitfire1900 changed the title Add .devcontainer/devcontainer-lock.json Add .devcontainer/devcontainer-lock.json, resolve oxfmt issues with vscode May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant