Skip to content

fix(web): hide update toast action while running and complete#2655

Open
flamboh wants to merge 1 commit into
pingdotgg:mainfrom
flamboh:fix/provider-hide-toast-update
Open

fix(web): hide update toast action while running and complete#2655
flamboh wants to merge 1 commit into
pingdotgg:mainfrom
flamboh:fix/provider-hide-toast-update

Conversation

@flamboh
Copy link
Copy Markdown

@flamboh flamboh commented May 12, 2026

What Changed

The update toast no longer shows the "Update" button while updating is in progress or complete. This is done by clearing the stale toast action props when the toast enters running/success state.

Why

Including this stale "Update" button can make it look like the update has failed to start. Fixing this cleans up the toast, making it clearer that the update is actually going through.

UI Changes

Before:

image
Screen.Recording.2026-05-11.at.9.31.31.PM.mov

After:

image
Screen.Recording.2026-05-11.at.9.30.05.PM.mov

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Hide action button in provider update toast during loading and success states

In ProviderUpdateLaunchNotification.tsx, updateProviderUpdateToast now passes actionProps: undefined when the view type is loading or success, removing the action button from the toast while an update is running or complete.

Macroscope summarized 23a54cf.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c3e85bbd-b4be-4eff-8e8a-e7ab50e9e00f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels May 12, 2026
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 12, 2026

Approvability

Verdict: Approved

Single-line UI fix that explicitly hides the toast action button during loading and success states. Low-risk, self-contained change with clear intent.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant