-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Smoke test bundled CLI before publish #2656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
delusionofgrandeur
wants to merge
1
commit into
pingdotgg:main
Choose a base branch
from
delusionofgrandeur:fix/project-cli-bundled-effect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+55
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // @effect-diagnostics nodeBuiltinImport:off | ||
| import { execFileSync } from "node:child_process"; | ||
| import { existsSync, mkdtempSync, rmSync } from "node:fs"; | ||
| import { tmpdir } from "node:os"; | ||
| import { dirname, join, resolve } from "node:path"; | ||
| import { fileURLToPath } from "node:url"; | ||
| import * as Console from "effect/Console"; | ||
| import * as Effect from "effect/Effect"; | ||
|
|
||
| const serverRoot = resolve(dirname(fileURLToPath(import.meta.url)), ".."); | ||
| const bundledCliPath = resolve(serverRoot, "dist/bin.mjs"); | ||
|
|
||
| if (!existsSync(bundledCliPath)) { | ||
| throw new Error(`Missing bundled CLI at ${bundledCliPath}. Run the server build first.`); | ||
| } | ||
|
|
||
| const baseDir = mkdtempSync(join(tmpdir(), "t3-cli-bundle-smoke-base-")); | ||
| const workspaceRoot = mkdtempSync(join(tmpdir(), "t3-cli-bundle-smoke-workspace-")); | ||
|
|
||
| try { | ||
| const output = execFileSync( | ||
| process.execPath, | ||
| [ | ||
| bundledCliPath, | ||
| "project", | ||
| "add", | ||
| workspaceRoot, | ||
| "--title", | ||
| "Bundle Smoke", | ||
| "--base-dir", | ||
| baseDir, | ||
| ], | ||
| { | ||
| cwd: serverRoot, | ||
| encoding: "utf8", | ||
| stdio: ["ignore", "pipe", "inherit"], | ||
| }, | ||
| ); | ||
|
|
||
| if (!output.includes("Added project")) { | ||
| throw new Error(`Bundled CLI smoke did not add a project. Output:\n${output}`); | ||
| } | ||
|
|
||
| Effect.runSync(Console.log("Bundled CLI smoke checks passed.")); | ||
| } finally { | ||
| rmSync(baseDir, { recursive: true, force: true }); | ||
| rmSync(workspaceRoot, { recursive: true, force: true }); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary Effect imports for simple console.log
Low Severity
effect/Consoleandeffect/Effectare imported solely forEffect.runSync(Console.log(...)), which is functionally identical toconsole.log(...). A smoke test that validates a bundled artifact ideally avoids pulling in the very framework being tested as a transitive dependency; a plainconsole.logkeeps the script minimal and removes two unused-beyond-one-line imports.Additional Locations (1)
apps/server/scripts/smoke-cli-bundle.ts#L43-L44Reviewed by Cursor Bugbot for commit e6ecfab. Configure here.