Add expandable runtime warning details to the work log#2672
Add expandable runtime warning details to the work log#2672justsomelegs wants to merge 3 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review 1 blocking correctness issue found. This PR introduces a new user-facing feature with collapsible UI components and new data propagation paths. Additionally, an unresolved review comment identifies a potential bug where entries with whitespace-only warning messages could render with no visible information. You can customize Macroscope's approvability policy. Learn more. |
What Changed
runtime.warningentries in the work log.Runtime Warning.WARNINGlabel.Runtime warningtoRuntime Warning.Why
runtime.warningentries were hard to use in the work log because they only surfaced a generic label with no way to inspect the underlying warning context inline. This change keeps the timeline compact by default, but makes warning details available on demand in a way that matches existing UI patterns.I kept the server-side truncation in place because removing it made the persisted activity payload unbounded, which is a bad tradeoff for a work-log projection. keeps the change focused on UI ergonomics instead of changing runtime payload size behavior.
UI Changes
Runtime Warningentry.Checklist
Note
Add expandable runtime warning details to the work log
runtimeWarningMessageandruntimeWarningDetailfields onWorkLogEntryin session-logic.ts; runtime warning entries no longer populate the genericdetailfield.normalizeRuntimeWarningMessageandformatRuntimeWarningDetailutilities in MessagesTimeline.tsx to handle whitespace-only messages and non-string detail values (pretty-printed JSON).activity.summaryas their label (capitalized "Runtime Warning") and omit the generic detail field.Macroscope summarized a8ea52b.