Skip to content

Add expandable runtime warning details to the work log#2672

Open
justsomelegs wants to merge 3 commits into
pingdotgg:mainfrom
justsomelegs:t3code/b5c7835f
Open

Add expandable runtime warning details to the work log#2672
justsomelegs wants to merge 3 commits into
pingdotgg:mainfrom
justsomelegs:t3code/b5c7835f

Conversation

@justsomelegs
Copy link
Copy Markdown
Contributor

@justsomelegs justsomelegs commented May 13, 2026

What Changed

  • Added expandable details for runtime.warning entries in the work log.
  • Kept the collapsed row compact and consistent as Runtime Warning.
  • Made the warning row itself clickable, with the chevron acting as open/closed state only.
  • Rendered expanded warning content inline without the extra bordered container or duplicate WARNING label.
  • Preserved the existing server-side truncation guard for warning messages.
  • Capitalized the stored warning summary from Runtime warning to Runtime Warning.

Why

runtime.warning entries were hard to use in the work log because they only surfaced a generic label with no way to inspect the underlying warning context inline. This change keeps the timeline compact by default, but makes warning details available on demand in a way that matches existing UI patterns.

I kept the server-side truncation in place because removing it made the persisted activity payload unbounded, which is a bad tradeoff for a work-log projection. keeps the change focused on UI ergonomics instead of changing runtime payload size behavior.

UI Changes

  • Collapsed state: warning rows continue to appear as a compact Runtime Warning entry.
Screenshot 2026-05-13 134115
  • Expanded state: clicking the row reveals the warning message and any structured detail inline beneath it.
Screenshot 2026-05-13 135035

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Add expandable runtime warning details to the work log

  • Adds collapsible runtime warning rows in the work log: a toggle button reveals the warning message and structured detail, collapsed by default.
  • Introduces runtimeWarningMessage and runtimeWarningDetail fields on WorkLogEntry in session-logic.ts; runtime warning entries no longer populate the generic detail field.
  • Adds normalizeRuntimeWarningMessage and formatRuntimeWarningDetail utilities in MessagesTimeline.tsx to handle whitespace-only messages and non-string detail values (pretty-printed JSON).
  • Suppresses preview text for entries that have renderable runtime warning metadata.
  • Behavioral Change: runtime warning work log entries now use activity.summary as their label (capitalized "Runtime Warning") and omit the generic detail field.

Macroscope summarized a8ea52b.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 371e7274-9cca-479b-a8c3-772eeb9d3156

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels May 13, 2026
Comment thread apps/web/src/components/chat/MessagesTimeline.tsx Outdated
@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp Bot commented May 13, 2026

Approvability

Verdict: Needs human review

1 blocking correctness issue found. This PR introduces a new user-facing feature with collapsible UI components and new data propagation paths. Additionally, an unresolved review comment identifies a potential bug where entries with whitespace-only warning messages could render with no visible information.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant