Skip to content

Allow removing reconnecting remote environments#3897

Open
OpeOginni wants to merge 1 commit into
pingdotgg:mainfrom
OpeOginni:fix/remove-connecting-remote-env
Open

Allow removing reconnecting remote environments#3897
OpeOginni wants to merge 1 commit into
pingdotgg:mainfrom
OpeOginni:fix/remove-connecting-remote-env

Conversation

@OpeOginni

@OpeOginni OpeOginni commented Jul 11, 2026

Copy link
Copy Markdown

What Changed

Added a Remove button for Remote Environments that remain in the reconnecting state.

AKA, auth went through, but something else is broken.

Why

Solves #3896 Where if your remote server doesn't ever resolve, you have no way to remove "forever" reconnecting servers from the Desktop app.

UI Changes

Before

Screenshot 2026-07-11 at 23 19 38

After

Screen.Recording.2026-07-11.at.23.22.16.mov

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Low Risk
Small UI-only change in Connections settings; reuses existing remove-environment flow with no new backend or auth logic.

Overview
Saved remote environment rows in Connections settings now treat reconnecting separately from connecting.

While a backend is stuck reconnecting, the action button stays enabled and calls onRemove (same catalog remove as disconnect), with Remove / Removing… labels instead of a disabled control that only offered Connect. Connected rows still show Disconnect; initial connect still disables the button and shows Connecting….

Reviewed by Cursor Bugbot for commit 973bb2a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Allow removing remote environments in the reconnecting state

In ConnectionsSettings.tsx, the SavedBackendListRow action button previously showed "Connecting…" and was disabled during the reconnecting phase. It now shows "Remove" (or "Removing…" while in-progress) and triggers onRemove, matching the behavior of the connected state. A separate isReconnecting flag distinguishes reconnecting from the initial connecting phase, so isConnecting no longer covers reconnection.

Macroscope summarized 973bb2a.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: df6cfe5e-ff82-4cfd-8dd0-71b0a98c1c3c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Jul 11, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

Small, self-contained UX fix that allows users to remove remote environments stuck in 'reconnecting' state. Changes are limited to button behavior and labels in a single UI component with no broader runtime impact.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant