Skip to content

chore(sdk): enforce explicit TLS verification on GraphQL transport#293

Merged
adriannoes merged 2 commits into
mainfrom
chore/enforce-tls-verification
Jun 12, 2026
Merged

chore(sdk): enforce explicit TLS verification on GraphQL transport#293
adriannoes merged 2 commits into
mainfrom
chore/enforce-tls-verification

Conversation

@adriannoes

Copy link
Copy Markdown
Collaborator

Summary

  • Add verify=True explicitly when constructing HTTPXAsyncTransport in BasePipefyClient.execute_query.
  • Add a unit test asserting TLS verification is enabled on every transport build.
  • Document the change under [Unreleased] in CHANGELOG.md.

validate_https_url on settings is intentionally deferred to a follow-up PR.

Test plan

  • uv run pytest packages/sdk/tests -m "not integration" — 874 passed
  • uv run ruff check .

Comment thread CHANGELOG.md Outdated
Pin intent explicitly rather than implying httpx default was unsafe.
@adriannoes adriannoes merged commit 8934b42 into main Jun 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants