Conversation
3 tasks
There was a problem hiding this comment.
Pull request overview
This PR extends understanding-check responses so the frontend can render response participation counts using session attendance as the denominator.
Changes:
- Adds
respondedCountandattendanceCountto understanding-check DTOs. - Counts attended users by session date and AM/PM attendance order.
- Wires attendance counts into question-room lookup and response submission results.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
QuestionService.java |
Calculates and returns response and attendance counts for understanding checks. |
QuestionResDTO.java |
Extends response records with participation-count fields. |
AttendanceService.java |
Adds session-to-attendance-order mapping and attendance counting logic. |
AttendanceRepository.java |
Adds query for counting completed attendance by date and order. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
#122
📝작업 내용
이해도 체크 응답 DTO 확장
respondedCount추가attendanceCount추가understoodCount,notUnderstoodCount는 O/X 뱃지 숫자로 유지"13/29"형태의 응답 현황을 바로 렌더링할 수 있도록 구조 변경세션 기준 출석 인원 계산 로직 추가
AM세션은 출석 1회차PM세션은 출석 2회차로 매핑AttendanceRepository에 출석 완료 인원 조회 쿼리 추가질문방/이해도 조회 API에 출석 인원 연결
이해도 체크 생성 응답 형식 정리
respondedCount,understoodCount,notUnderstoodCount는 0으로 반환attendanceCount는null로 반환