Reopen in maintenance mode by tonistiigi · Pull Request #247 · pkg/errors

tonistiigi · 2026-03-26T22:52:36Z

Maintainers from @moby project can take over keeping this repo available in maintenance mode.

From README:

This package is in maintenance mode. New features that extend the scope of the package are not being accepted and should be implemented in other modules. Exceptions would be features that improve interoperability with the standard library's errors package when it receives new features, as pkg/errors should mostly be able to act as a drop-in replacement. Bug fixes and reports are welcome. CI will be maintained to make sure the package is tested against new versions of Go and Go linting tools.

@thaJeztah

Add go.mod, targets to build, test and lint. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

crazy-max

Needs to bump actions to latest stable following Node 20 EOL coming soon on GitHub Hosted runners

.github/workflows/ci.yml

README.md

bench_test.go

go113.go

go113_test.go

json_test.go

thaJeztah · 2026-03-28T13:46:36Z

format_test.go

 		"error\n" +
 			"github.com/pkg/errors.TestFormatNew\n" +
-			"\t.+/github.com/pkg/errors/format_test.go:26",
+			"\t.+/format_test.go:26",


Curious about these; were the tests wrong, or did behavior change between Go versions? (ISTR something changed in some of stdlib).

If it changed in Go, was that before, or after go1.20 (otherwise tests won't be valid with the minimum version specified in go.mod)

These tests were pre-gomod and expected checkout to be in GOPATH that is not a requirement anymore.

thaJeztah · 2026-03-28T13:48:38Z

unwrap.go

-//go:build go1.13
-// +build go1.13
-
 package errors


I would squash the removal of the tags with the previous commits, but keep the removal of the Makefile in this one.

These are opinionated changes, while the first commit is purely making the linter and test pass with the recent version of Go without changing anything about the code. Moved the makefile away.

thaJeztah · 2026-03-28T13:50:05Z

astype.go

+//go:build !go1.26
+
+package errors


This commit starts the work of picking up maintenance; I think it would make sense to move this (and forward) separate.

(Steps before this were just setting the baseline)

Moved to last

thaJeztah · 2026-03-28T13:52:52Z

bench_test.go

 // GlobalE is an exported global to store the result of benchmark results,
 // preventing the compiler from optimising the benchmark functions away.
-var GlobalE interface{}
+var GlobalE any


any was added in go1.18, and the module already had go1.20 as minimum; I think we can squash this one with the "fix linting" commit, or move it before the addition of the go1.26 features.

modernize is not same as lint. These changes make the code use the latest conventions but are not required for the code to work properly and lint pass in recent Go.

thaJeztah · 2026-03-28T13:55:22Z

.github/workflows/ci.yml

+    branches:
+      - master


Perhaps add main to the list, so that we can rename the default branch.

This commit could also be put before the go1.26 feature commit, making it part of the "baseline".

Renaming branches does not seem compliant with maintenance mode.

thaJeztah · 2026-03-28T13:58:58Z

Left some comments (sorry I reviewed per commit, so some got superseded in later commits).

Overall looks good; some things I think we should do;

Some commits can be squashed (see my comments)
Move the fix linting, remove old CI files, and general cleanups first
Move the go1.26 enhancement as a follow-up pull-request

puellanivis · 2026-03-28T19:41:48Z

I’m not sure the stacktrace feature is even useful. Most people tend to declare their errors at the top level, where the stacktrace ends up being _init anyways, and not anything useful pointing to where the error originated…

tonistiigi · 2026-03-30T05:56:41Z

@puellanivis There is no obligation to use this package. This package works well with typed/static/chained errors; you add the stack trace to the return path, not to the definition path, if you use static errors.

Fix gofmt formatting, simplify code patterns flagged by gocritic/staticcheck/revive, update test path expectations to not assume GOPATH layout. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

Remove go1.13 build constraints from unwrap functions since go.mod minimum is go1.20. Rename go113.go and go113_test.go to unwrap.go and unwrap_test.go. Delete Makefile as build/test/lint are now handled by Docker Bake targets. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

Remove defunct Travis-CI and AppVeyor badges. Replace the outdated Roadmap section with a comparison to the standard library's errors package. Update Contributing section to reflect current maintenance-mode policy. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

puellanivis

Yes, that was the going advice to people at the time: that global errors should use stderrors since this package’s stacktraces are really only useful when they appear at the return.

My point of raising this point was that use of this package has always been with significant special caveats, and footguns. It was just that the calculus worked out in favor of using it, since one could wrap and unwrap errors.

Now, the whole utility of this package is really just the WithStack function, and I’m not really sure that the same calculus holds anymore. It might be better to just propose and implement a feature request on the standard errors package and add stack tracing to that.

It’s basically: there’s a reason why this package fell into an unmaintained state, and it was not really for lack of care or interest to maintain it.

puellanivis · 2026-03-30T16:20:46Z

errors.go

 // as a value that satisfies error.
 // Errorf also records the stack trace at the point it was called.
-func Errorf(format string, args ...interface{}) error {
+func Errorf(format string, args ...any) error {


🤔 With the now standard library Errorf using the %w verb, this function is now subtly different from how likely a large number of people are people are using fmt.Errorf. This creates a situation where we’re likely to create significant surprise.

puellanivis · 2026-03-30T16:27:01Z

unwrap_test.go

 	}
 }
+
+func TestJoin(t *testing.T) {


Since our Join is just return stderrors.Join(errs...), testing this is perhaps not particularly appropriate? It is, after all, not really our responsibility; it’s the standard library that has written the tests.

unwrap_test.go

puellanivis · 2026-03-30T16:35:51Z

unwrap_test.go

+	}
+}
+
+func TestAsTypeNotFound(t *testing.T) {


Unlike TestAsType above, and more like the TestJoin, we’re basically testing either stderrors.As or stderrors.AsType… facing the same question of whose responsibility that testing belongs with, us, or stderrors.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

chore: add basic dev tools targets

18a238d

Add go.mod, targets to build, test and lint. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

crazy-max reviewed Mar 27, 2026

View reviewed changes

.github/workflows/ci.yml Show resolved Hide resolved

.github/workflows/ci.yml Show resolved Hide resolved

.github/workflows/ci.yml Show resolved Hide resolved

.github/workflows/ci.yml Outdated Show resolved Hide resolved

tonistiigi force-pushed the master branch from 1f47ecb to fff14a8 Compare March 27, 2026 15:12

crazy-max reviewed Mar 27, 2026

View reviewed changes

README.md Outdated Show resolved Hide resolved

tonistiigi force-pushed the master branch 4 times, most recently from 3b5125c to c321b9f Compare March 27, 2026 15:23

crazy-max approved these changes Mar 27, 2026

View reviewed changes

thaJeztah reviewed Mar 28, 2026

View reviewed changes

tonistiigi force-pushed the master branch from c321b9f to 8adc096 Compare March 30, 2026 05:45

tonistiigi added 5 commits March 29, 2026 23:06

lint: fix all golangci-lint issues and test failures

bcc7d34

Fix gofmt formatting, simplify code patterns flagged by gocritic/staticcheck/revive, update test path expectations to not assume GOPATH layout. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

modernize: replace interface{} with any and fix deepequalerrors

e13c645

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

ci: replace Travis/AppVeyor with GitHub Actions

05d4450

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

tonistiigi force-pushed the master branch from 8adc096 to 950340b Compare March 30, 2026 06:06

jonasz-lasut mentioned this pull request Mar 30, 2026

[Outdated Go Dependency] Usage of archived github.com/pkg/errors crossplane-contrib/provider-upjet-azure#1150

Closed

puellanivis reviewed Mar 30, 2026

View reviewed changes

feat: add Join and AsType standard library shortcuts

279ed80

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>

tonistiigi force-pushed the master branch from 950340b to 279ed80 Compare March 30, 2026 18:02

Conversation

tonistiigi commented Mar 26, 2026

Uh oh!

crazy-max left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tonistiigi Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thaJeztah commented Mar 28, 2026

Uh oh!

puellanivis commented Mar 28, 2026

Uh oh!

tonistiigi commented Mar 30, 2026

Uh oh!

puellanivis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tonistiigi Mar 30, 2026 •

edited

Loading