GlobalDeclareCheck: new check for declare -A without -g in global scope#779
Open
AngryLoki wants to merge 1 commit intopkgcore:masterfrom
Open
GlobalDeclareCheck: new check for declare -A without -g in global scope#779AngryLoki wants to merge 1 commit intopkgcore:masterfrom
AngryLoki wants to merge 1 commit intopkgcore:masterfrom
Conversation
Any use of declare is local scope unless a -g is passed. Missing -g can cause issues when the ebuild is sourced inside a function (as non-portage package managers may do). One example is pkgcore: when it processes ebuilds with declare -A without -g, it usually fails in configure phase (good outcome) or worse, it silently skips some files in install phase. The new check is added as a warning since Portage is not affected. Closes: pkgcore#628 Signed-off-by: Sv. Lockal <lockalsash@gmail.com>
Author
|
132 warnings in ::gentoo Results for ::gentoo
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any use of
declareis local scope unless a-gis passed. Missing-gcan cause issues when the ebuild is sourced inside a function (as non-portage package managers may do).One example is pkgcore: when it processes ebuilds with
declare -Awithout-g, it usually fails in configure phase (good outcome) or worse, it silently skips some files in install phase.The new check is added as a warning since Portage is not affected.
Closes: #628