repo: force existent key params for __getitem__()

Author: radhermit

src/pkgcraft/repo/base.pyx

@@ -105,12 +105,12 @@ cdef class Repo:
             return C.pkgcraft_repo_contains_path(self.ptr, str(obj).encode())
         return bool(next(self.iter(obj), None))
 
-    def __getitem__(self, object obj not None):
-        if pkgs := list(self.iter(obj)):
+    def __getitem__(self, object key not None):
+        if pkgs := list(self.iter(key)):
             if len(pkgs) > 1:
                 return pkgs
             return pkgs[0]
-        raise KeyError(obj)
+        raise KeyError(key)
 
     def __iter__(self):
         return _Iter.create(self)

src/pkgcraft/repo/set.pyx

@@ -39,7 +39,7 @@ cdef class RepoSet:
     def __iter__(self):
         return _Iter(self)
 
-    def __getitem__(self, key):
+    def __getitem__(self, object key not None):
         if isinstance(key, int):
             # return a singular Repo for integers
             return self.repos[key]

tests/repo/base.py

@@ -115,10 +115,16 @@ def test_getitem_base(self, repo):
         assert pkg2 == repo[Dep(">=cat/pkg-2")]
         assert [pkg1, pkg2] == repo["cat/pkg"]
 
+        # nonexistent matches
         for obj in ("cat/pkg-3", Cpv("cat/pkg-3"), Dep("<cat/pkg-1")):
             with pytest.raises(KeyError):
                 _ = repo[obj]
 
+        # invalid key types
+        for obj in (object(), None):
+            with pytest.raises(TypeError):
+                repo[obj]
+
     def test_bool_and_len_base(self, repo):
         # empty repo
         assert not repo

tests/repo/test_set.py

@@ -171,6 +171,11 @@ def test_getitem(self, make_fake_repo):
         assert s[Dep("=cat/pkg-1::r2")] == pkg1
         assert s["cat/pkg-2"] == pkg2
 
+        # invalid key types
+        for obj in (object(), None):
+            with pytest.raises(TypeError):
+                s[obj]
+
     def test_bool_and_len(self, make_fake_repo):
         s = self.cls()
         assert not s