Allow ignoring unknown metadata#360
Open
parched wants to merge 4 commits into
Open
Conversation
Allow parsing union variant metadata, preserve it in CST/formatter, and reject it semantically * Parse and keep metadata on union variants in the CST so formatting can round-trip it. * Update formatter handling so union variant metadata is visible to formatting logic instead of being discarded. * Add semantic validation that rejects union variant metadata with a clear error. * Current behavior: union variant metadata syntax is accepted by the parser, but no metadata keys are supported semantically yet. Note: AI was used in some of this.
When using flatbuffers to share data between different languages that have different generators there can be attributes that are specific to one particular generator. E.g., https://github.com/jamescourtney/FlatSharp/wiki/FBS-Annotations#flatsharp-fbs-extensions In this case, the other generators should just ignore these attributes. Note: implemented using AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #312
When using flatbuffers to share data between different languages
that have different generators there can be attributes that are specific
to one particular generator.
E.g., https://github.com/jamescourtney/FlatSharp/wiki/FBS-Annotations#flatsharp-fbs-extensions
In this case, the other generators should just ignore these attributes.
Note: implemented using AI
Checklist