Skip to content

Implement private/reserved IP lookup interface#6512

Open
aerosol wants to merge 5 commits into
masterfrom
ip-tools
Open

Implement private/reserved IP lookup interface#6512
aerosol wants to merge 5 commits into
masterfrom
ip-tools

Conversation

@aerosol

@aerosol aerosol commented Jul 16, 2026

Copy link
Copy Markdown
Member

Changes

Initial IP classification interface - to be built upon in follow-up PRs

Tests

  • Automated tests have been added
  • This PR does not require tests

Changelog

  • Entry has been added to changelog
  • This PR does not make a user-facing change

Documentation

  • Docs have been updated
  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
  • This PR does not change the UI

@aerosol
aerosol requested review from a team and cnkk July 16, 2026 06:45
Comment thread mix.exs
{:location, git: "https://github.com/plausible/location.git"},
{:mox, "~> 1.0", only: [:test, :ce_test, :e2e_test]},
{:nanoid, "~> 2.1.0"},
{:nimble_csv, "~> 1.3"},

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used elsewhere too but was never put up as an explicit dependency

@aerosol
aerosol requested a review from ukutaht July 16, 2026 06:49

@zoldar zoldar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mad props for figuring out translating ip/mask to patterns/guards 🙇

Comment thread lib/mix/tasks/download_ip_registries.ex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants