Skip to content

Clean up #605

Merged
davisagli merged 3 commits into
mainfrom
ale/typing-backports
May 29, 2026
Merged

Clean up #605
davisagli merged 3 commits into
mainfrom
ale/typing-backports

Conversation

@ale-rt
Copy link
Copy Markdown
Member

@ale-rt ale-rt commented May 27, 2026 •
edited
Loading

Backport some clean up from #592

  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

📚 Documentation preview 📚: https://ploneapi--605.org.readthedocs.build/

@mister-roboto
Copy link
Copy Markdown

mister-roboto commented May 27, 2026

@ale-rt thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@ale-rt
Copy link
Copy Markdown
Member Author

ale-rt commented May 27, 2026

@jenkins-plone-org please run jobs

@ale-rt ale-rt force-pushed the ale/typing-backports branch from ff54ae7 to 7f3ce38 Compare May 27, 2026 20:32
davisagli
davisagli reviewed May 27, 2026
View reviewed changes
Comment thread src/plone/api/tests/test_portal.py
@ale-rt
Clean up
62f3fc7 
Backport some clean up from #592
@ale-rt ale-rt force-pushed the ale/typing-backports branch from 7f3ce38 to 62f3fc7 Compare May 27, 2026 20:46
@ale-rt
Copy link
Copy Markdown
Member Author

ale-rt commented May 27, 2026

@jenkins-plone-org please run jobs

@ale-rt ale-rt requested a review from davisagli May 27, 2026 20:47
davisagli
davisagli reviewed May 28, 2026
View reviewed changes
Comment thread src/plone/api/user.py Outdated

roles = set(roles)
if not isinstance(roles, (list, tuple)):
raise InvalidParameterError("Roles must be a list or a tuple of strings")
Copy link
Copy Markdown
Member

@davisagli davisagli May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't it be any iterable?

Copy link
Copy Markdown
Member Author

@ale-rt ale-rt May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most probably to please mypy. I will fix that.

Copy link
Copy Markdown
Member Author

@ale-rt ale-rt May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up wrapping that in a try except.

@ale-rt
Copy link
Copy Markdown
Member Author

ale-rt commented May 28, 2026

@jenkins-plone-org please run jobs

@davisagli davisagli merged commit 829547a into main May 29, 2026
15 checks passed
@davisagli davisagli deleted the ale/typing-backports branch May 29, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davisagli davisagli davisagli left review comments

@gforcada gforcada gforcada approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ale-rt @mister-roboto @davisagli @gforcada