Fix skill flag parsing and default skill install to user scope#99
Merged
Conversation
- Allow options after the action argument for the chained skill command (e.g. `plonecli skill install --force`) via an InterspersedCommand parser. - Default `plonecli skill install|update` to --scope user so it no longer installs into the current directory; --scope project keeps the old behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plonecli skill install --force(and any flag placed after theinstall/update/statusaction) was rejected withNo such option. The top-level CLI group ischain=True, which disables interspersed args for every subcommand, so flags after a positional argument leaked back to the parent parser. Fixed with anInterspersedCommandparser applied only to theskillcommand; chaining is preserved.plonecli skill install|updatenow defaults to--scope user, installing into~/.agents/skills/plonecli+~/.claude/skills/plonecliinstead of the current working directory. This avoids clobbering the dev checkout when run from the source repo. Use--scope projectfor a project-local install.Test plan
uv run pytest— 75 passed, 1 pre-existing skipplonecli skill install --forceinstalls/overwrites as advertisedplonecli skill installlands in user home, leaves cwd untouched (verified with a throwaway HOME and a new unit test)skill status+ a chained command)