Skip to content

chore: remove dlv dependency #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gameroman wants to merge 3 commits into
base: main
Choose a base branch
from
+10 −13
Open

chore: remove dlv dependency #503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83e8444
chore: remove dlv dependency
gameroman Apr 8, 2026
1901ec5
use `for...of`
gameroman Apr 8, 2026
f907765
chore: replace with `.reduce`
gameroman Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/node-plop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
"@types/inquirer": "^9.0.9",
"@types/picomatch": "^4.0.2",
"change-case": "^5.4.4",
"dlv": "^1.1.3",
"handlebars": "^4.7.8",
"inquirer": "^9.3.8",
"isbinaryfile": "^6.0.0",
Expand Down
14 changes: 10 additions & 4 deletions packages/node-plop/src/node-plop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import fs from "fs";
import path from "path";
import inquirer from "inquirer";
import handlebars from "handlebars";
import dlv from "dlv";
import resolve from "resolve";

import bakedInHelpers from "./baked-in-helpers.js";
Expand All @@ -12,8 +11,15 @@ import { createRequire } from "node:module";
import { pathToFileURL } from "url";
const require = createRequire(import.meta.url);

const dlvBrackets = (obj, propertyPath, defaultValue) =>
dlv(obj, propertyPath.replace("[", ".").replace("]", ""), defaultValue);
function dlvBrackets(obj, key) {
const result = key
.replace("[", ".")
.replace("]", "")
.split(".")
.reduce((acc, k) => acc?.[k], obj);

return result ?? "";
}

async function nodePlop(plopfilePath = "", plopCfg = {}) {
let pkgJson = {};
Expand All @@ -26,7 +32,7 @@ async function nodePlop(plopfilePath = "", plopCfg = {}) {
const actionTypes = {};
const helpers = Object.assign(
{
pkg: (propertyPath) => dlvBrackets(pkgJson, propertyPath, ""),
pkg: (propertyPath) => dlvBrackets(pkgJson, propertyPath),
},
bakedInHelpers,
);
Expand Down
8 changes: 0 additions & 8 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2526,13 +2526,6 @@ __metadata:
languageName: node
linkType: hard

"dlv@npm:^1.1.3":
version: 1.1.3
resolution: "dlv@npm:1.1.3"
checksum: 10/836459ec6b50e43e9ed388a5fc28954be99e3481af3fa4b5d82a600762eb65ef8faacd454097ed7fc2f8a60aea2800d65a4cece5cd0d81ab82b2031f3f759e6e
languageName: node
linkType: hard

"dotenv@npm:^8.1.0":
version: 8.6.0
resolution: "dotenv@npm:8.6.0"
Expand Down Expand Up @@ -4914,7 +4907,6 @@ __metadata:
"@types/node": "npm:^24.1.0"
"@types/picomatch": "npm:^4.0.2"
change-case: "npm:^5.4.4"
dlv: "npm:^1.1.3"
dtslint: "npm:^4.2.1"
handlebars: "npm:^4.7.8"
inquirer: "npm:^9.3.8"
Expand Down