[flpi-sun]

Closes #5703

Description of change

Include all xNranges / yNranges in selector_state.
This enables getting the box selection size in any number of subplots.

Demo

Testing strategy

I created the following python file for testing called test_subplot_selection.py:

"""
Test script to verify subplot-specific selector keys are preserved.

Run with:
  solara run test_subplot_selection.py

Then:
1. Click "Box Select" tool in the toolbar
2. Make a selection in the SECOND subplot (Bar chart) - NOT the first one
3. Check the console output for the selector data
4. Verify that x2range and y2range (or similar x2, y2 keys) are present in selector_state
"""

import plotly.graph_objects as go
import solara
from plotly.subplots import make_subplots
import json


def build_figure() -> go.Figure:
    fig = make_subplots(rows=1, cols=2, subplot_titles=("Scatter", "Bar"))
    fig.add_trace(
        go.Scatter(x=[1, 2, 3, 4, 5, 6], y=[2, 1, 3, 5, 4, 6], name="Series A"),
        row=1,
        col=1,
    )
    fig.add_trace(
        go.Bar(x=["A", "B", "C"], y=[3, 1, 2], name="Series B"), row=1, col=2
    )
    fig.update_layout(title="FigureWidget example with 2 subplots")
    return fig


@solara.component
def Page():
    selection_data, set_selection_data = solara.use_state(None)
    def on_selection(data):
        set_selection_data(data)
    with solara.Column():
        solara.FigurePlotly(build_figure(), on_selection=on_selection)
        if selection_data:
            with solara.Column():
                solara.Markdown("### Last Selection Data (Pretty-printed)")
                solara.Markdown(
                    f"```json\n{json.dumps(selection_data, indent=2, default=str)}\n```"
                )

Guidelines

• I have reviewed the pull request guidelines and the Code of Conduct and confirm that this PR follows them.
• I have added an entry to the changelog if needed (not required for documentation PRs).

[camdecoster]

Thanks for the PR! Could you please address the merge conflicts and merge main into your branch?

[flpi-sun]

Thanks for the PR! Could you please address the merge conflicts and merge main into your branch?

Done

[camdecoster]

Could you rebuild the widget bundle again? We released a new version between your last update and today. Sorry for the churn.

[flpi-sun]

Could you rebuild the widget bundle again? We released a new version between your last update and today. Sorry for the churn.

No problem. I rebased the branch and rebuild the widget bundle now.

[flpi-sun]

@camdecoster Could you take a look ?

[camdecoster]

Before moving forward, what are you trying to accomplish with making the selection in the second subplot? As of now, there's no way to get the range without digging into private values. There could be a workaround, but that depends on what you're trying to do.

[flpi-sun]

Before moving forward, what are you trying to accomplish with making the selection in the second subplot? As of now, there's no way to get the range without digging into private values. There could be a workaround, but that depends on what you're trying to do.

I don't get it. I am only exposing the interface that is already provided by Plotly.js, I am not accessing any private values.
This already is the status qou for Plotly.js where you can access any selection in subplot 1 or n. (x, x2, ... xn)

My use-case is the following: I have two subplots with different time ranges. In one subplot there is a part where data is missing. A user shall then be able to select said x-range to annotate why data is missing there.

[camdecoster]

I was trying to find out if you could use one of the workarounds I was referencing. Upon digging into this, I think there's another path forward: create the selector per trace.

Your fix to pass the range through is correct, but it only gets us part of the way there. Right now, the selector is created once and handed to every trace, which creates problems because selecting in one subplot reports that selection to every other subplot. If we create a selector per trace, we can determine the correct axis from trace data and we don't have to determine it later.

The end result: with your changes and those I describe above, the bug should be taken care of. I'll push my changes soon.

[camdecoster]

@flpi-sun I've pushed my changes. Could you run some tests on your end and see if things are working?

[flpi-sun]

I pulled your changes and tested it again with the example above:

It seems to work as expected :)

[camdecoster]

Thanks for the fix (and your patience)!