feat: add ScatterMap trace for the MapLibre map subplot#417
Open
jqnatividad wants to merge 5 commits into
Open
feat: add ScatterMap trace for the MapLibre map subplot#417jqnatividad wants to merge 5 commits into
jqnatividad wants to merge 5 commits into
Conversation
Add choropleth map support (addresses plotly#408): - `Choropleth<Loc, Z>` on the existing `geo` subplot, with a `LocationMode` enum (ISO-3 / USA-states / country names / geojson-id), a dedicated `choropleth::Marker`, selection support, z-bounds, and the shared `ColorScale`/`ColorBar` machinery. `geojson` accepts a URL string or an inline GeoJSON object. - `ChoroplethMap<Loc, Z>`, the plotly.js 3.x `choroplethmap` trace on the MapLibre `map` subplot (GeoJSON-only). - New MapLibre `map` subplot via `LayoutMap` + `MapStyle` + `MapBounds`. - `LayoutGeo` additions: `fitbounds` (`GeoFitBounds`), `resolution` (`GeoResolution`, 1:110M/1:50M base-layer detail), and `bgcolor`. - `PlotType::Choropleth`/`ChoroplethMap` variants, re-exports, serialization tests, doctests, runnable `examples/maps` examples, and a Maps book recipe. Attribute names/types follow the plotly.js v3.6.0 plot-schema. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The embedded choropleth example calls GeoResolution::OneOverFiftyMillion, but the shared import block omitted GeoResolution, so copying the documented imports alongside the example would not compile. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add the modern MapLibre-based `densitymap` trace type, the density counterpart to `ChoroplethMap`. It draws a weighted kernel-density heatmap from lat/lon points (optional per-point weight z) onto the `layout.map` subplot, with full color-scale (colorscale, colorbar, showscale, reversescale, autocolorscale, coloraxis, zmin/zmax/zmid) and hover (text, hovertext, hoverinfo, hovertemplate, hoverlabel, customdata) support. Unlike ChoroplethMap it has no marker/selection. Registers the trace: DensityMap variant on PlotType (serializes to "densitymap"), module + type re-exports in traces/mod.rs and lib.rs. Includes a serialize_density_map unit test and a doctest. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add `ScatterMap`, the MapLibre-based counterpart to `ScatterMapbox`, drawn on the `layout.map` subplot (`LayoutMap`/`MapStyle`). It mirrors `ScatterMapbox` field-for-field — markers/lines, `Fill`/`Selection`, and the full hover set (text/hovertext/hoverinfo/hovertemplate/customdata/hoverlabel) — but emits `"type": "scattermap"` and references `layout.map`. Add a `PlotType::ScatterMap` variant, re-export `ScatterMap` and the `scatter_map` module, and add a `serialize_scatter_map` unit test plus a doc example. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plotly.rs has
ChoroplethMapandDensityMap(#416) for the modern MapLibremapsubplot (layout.map), but no scatter/marker trace for it. plotly.js providesscattermapas the MapLibre-based successor to the (Mapbox-based, now deprecated)scattermapbox. This PR adds a matchingScatterMapRust trace.ScatterMapis drawn on the MapLibremapsubplot introduced in #410 (viaLayoutMap/MapStyle), so this PR is stacked on top of #416 → #410 and should be reviewed/merged after them. Until they merge, the diff here also shows their commits; once they land inmain, this diff reduces to just theScatterMapaddition. (Depends on #410; branched off #416 for a linear map-trace stack.)What changed
New
ScatterMap<Lat, Lon>trace mirroringScatterMapboxfield-for-field, but drawn onlayout.mapand emitting"type": "scattermap":lat,lon,mode,marker,line,opacity,connectgapsFillenum (none/toself),Selection/SelectionMarker(selected/unselected/selectedpoints),fill,fillcolortext,textposition,texttemplate,texttemplatefallback,textfonttext,hovertext,hoverinfo,hovertemplate,hovertemplatefallback,hoverlabelname,visible,showlegend,legendrank,legendgroup,legendgrouptitle,subplot(referenceslayout.map),below,ids,meta,customdata,uirevisionRegistration: a
ScatterMapvariant onPlotType(serializes to"scattermap"), plus module/type re-exports intraces/mod.rsandlib.rs. Includesserialize_scatter_map/serialize_fill/serialize_selectionunit tests and a doctest.Testing
cargo test -p plotly—serialize_scatter_mapand its doctest pass.cargo clippy --features all -- -D warnings -A deprecated— clean.cargo +nightly fmt --all -- --check— clean.🤖 Generated with Claude Code