Skip to content

Improve handling of missing thermostat data #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bouwew merged 18 commits into from
Mar 7, 2026
Merged

Improve handling of missing thermostat data #861

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9e32a0f
Add JVonk userdata
bouwew Mar 5, 2026
4be6c97
Test the added userdata
bouwew Mar 5, 2026
c630812
Debug
bouwew Mar 6, 2026
d8ae204
Guard for missing thermostat data
bouwew Mar 6, 2026
367391b
Move debug-logger
bouwew Mar 6, 2026
cf9e669
Update logger-message, remove test-debug-logger
bouwew Mar 6, 2026
d3fae83
Correct return
bouwew Mar 6, 2026
ac88dc4
Save reformatted files
bouwew Mar 6, 2026
06ae5fc
Rename folders
bouwew Mar 6, 2026
0dc5689
Save added fixture
bouwew Mar 6, 2026
d0caf24
Copy testdata from fixture
bouwew Mar 6, 2026
1dec4d3
Update CHANGELOG
bouwew Mar 6, 2026
718b3e0
Use get() to avoid potential error-case, improve message
bouwew Mar 7, 2026
a6d77f3
Clean up
bouwew Mar 7, 2026
b0002ea
Set to v1.11.3 release-version
bouwew Mar 7, 2026
302d6af
Shorten added userdata
bouwew Mar 7, 2026
82f1440
Update related json-files
bouwew Mar 7, 2026
0afb80b
Improve CHANGELOG
bouwew Mar 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# Changelog

## Ongoing
## v1.11.3

- More code optimizations via PR[#843](https://github.com/plugwise/python-plugwise/pull/843)
- Better handle missing thermostat data via PR [#860](https://github.com/plugwise/python-plugwise/pull/860)
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix the PR reference in the v1.11.3 entry.

Line 5 points to PR #860, but this change set is PR #861, so the changelog entry appears to link to the wrong implementation history.

✏️ Proposed fix 
-- Better handle missing thermostat data via PR [`#860`](https://github.com/plugwise/python-plugwise/pull/860)
+- Better handle missing thermostat data via PR [`#861`](https://github.com/plugwise/python-plugwise/pull/861)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Better handle missing thermostat data via PR [#860](https://github.com/plugwise/python-plugwise/pull/860)
- Better handle missing thermostat data via PR [`#861`](https://github.com/plugwise/python-plugwise/pull/861)
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@CHANGELOG.md` at line 5, Update the v1.11.3 changelog entry that currently
reads "Better handle missing thermostat data via PR [`#860`]" to reference the
correct pull request number `#861`; locate the string in CHANGELOG.md (the v1.11.3
line) and replace "[`#860`](https://github.com/plugwise/python-plugwise/pull/860)"
with "[`#861`](https://github.com/plugwise/python-plugwise/pull/861)" so the link
points to the correct PR.

- More code optimizations via PR [#843](https://github.com/plugwise/python-plugwise/pull/843)
- Chores:
- Introduce prek (for pre-commit) & align with v2 gh-actions
- Remove biome (as prettier was reinstated)
Expand Down
135 changes: 135 additions & 0 deletions fixtures/adam_bad_thermostat/data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,135 @@
{
"292c5988ac814684bc1ade6286a8248b": {
"available": true,
"binary_sensors": {
"dhw_state": false,
"flame_state": false,
"heating_state": false
},
"dev_class": "heater_central",
"location": "856285a783f24bf4b2573c8bc510eabf",
"max_dhw_temperature": {
"lower_bound": 0.0,
"resolution": 1.0,
"setpoint": 50.0,
"upper_bound": 100.0
},
"maximum_boiler_temperature": {
"lower_bound": 25.0,
"resolution": 0.01,
"setpoint": 38.0,
"upper_bound": 45.0
},
"model": "Generic heater",
"model_id": "1.1",
"name": "OpenTherm",
"sensors": {
"dhw_temperature": 49.9,
"intended_boiler_temperature": 0.0,
"modulation_level": 0.0,
"outdoor_air_temperature": 13.6,
"return_temperature": 33.0,
"water_temperature": 20.9
},
"switches": {
"dhw_cm_switch": false
},
"vendor": "WeHeat"
},
"3ee6b9486cb04c258a3130fff2b144a4": {
"active_preset": "home",
"available_schedules": [],
"climate_mode": "heat",
"control_state": "idle",
"dev_class": "climate",
"model": "ThermoZone",
"name": "Overloop",
"preset_modes": [
"home",
"asleep",
"away",
"vacation",
"no_frost"
],
"select_schedule": null,
"sensors": {
"temperature": 20.3
},
"thermostats": {
"primary": [
"8edf4c8b659342e8ae9809a6f9734532"
],
"secondary": []
},
"vendor": "Plugwise"
},
"8edf4c8b659342e8ae9809a6f9734532": {
"available": true,
"binary_sensors": {
"low_battery": false
},
"dev_class": "zone_thermometer",
"firmware": "2023-06-12T02:00:00+02:00",
"hardware": "1",
"location": "3ee6b9486cb04c258a3130fff2b144a4",
"model": "Jip",
"model_id": "168-02",
"name": "Jip overloop ",
"sensors": {
"battery": 100,
"humidity": 53.6,
"temperature": 20.3
},
"vendor": "Plugwise",
"zigbee_mac_address": "3C2EF5FFFED5DB5B"
},
"b0db639e4cf14e0ba3e586eb18febc36": {
"available": true,
"dev_class": "valve_actuator_plug",
"hardware": "1",
"location": "3ee6b9486cb04c258a3130fff2b144a4",
"model": "Aqara Smart Plug",
"model_id": "lumi.plug.maeu01",
"name": "Koen overloop",
"sensors": {
"electricity_consumed_interval": 0.0
},
"switches": {
"relay": false
},
"vendor": "LUMI",
"zigbee_mac_address": "54EF441000810C91"
},
"d4ad887fc59a4454bdcda64bbcf2d9ab": {
"binary_sensors": {
"plugwise_notification": false
},
"dev_class": "gateway",
"firmware": "3.10.13",
"gateway_modes": [
"away",
"full",
"vacation"
],
"hardware": "AME Smile 2.0 board",
"location": "856285a783f24bf4b2573c8bc510eabf",
"mac_address": "C493004A803A",
"model": "Gateway",
"model_id": "smile_open_therm",
"name": "Adam",
"notifications": {},
"regulation_modes": [
"off",
"bleeding_hot",
"bleeding_cold",
"heating"
],
"select_gateway_mode": "full",
"select_regulation_mode": "heating",
"sensors": {
"outdoor_temperature": 15.6
},
"vendor": "Plugwise",
"zigbee_mac_address": "000D6F000DB9F188"
}
}
Loading