Add an extra fixture for testing in the Integration#878
Conversation
|
Warning Review limit reached
Your plan includes 1 review of capacity. Refill in 11 minutes and 12 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds a new test fixture variant ChangesAdam heating off-schedule fixture generation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3457 3457
=========================================
Hits 3457 3457 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/manual_fixtures.py`:
- Around line 202-225: The patch mistakenly mutates m_adam_heating instead of
the intended m_adam_heating_off_schedule, causing alias-dependent output; fix by
creating m_adam_heating_off_schedule as a deep copy (use copy.deepcopy) of
m_adam_heating or by applying all subsequent overrides to
m_adam_heating_off_schedule (e.g., updates for keys
"f2bf9048bef64cc5b6d5110154e33c81", "f871b8c4d63549319221e294e4f88074",
"da224107914542988a88561b4452b0f6", "056ee145a816487eaa69243c3280f8bf") so
json_writer("m_adam_heating_off_schedule", m_adam_heating_off_schedule) writes
an independently modified object.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1631afcc-bd4a-4927-a98b-d7666df8dd5c
📒 Files selected for processing (2)
fixtures/m_adam_heating_off_schedule/data.jsonscripts/manual_fixtures.py
|



Summary by CodeRabbit