Repository navigation
feat: notification catalog and device notifications (v0.14.0) - #33
Merged
Merged
Conversation
Add GET /v1/notification-catalog (every notification with an example
payload) and GET /v1/devices/{device_id}/notifications (matching routes,
webhook health, would_fire with a reason, recent deliveries with payloads,
external refs). Migration 00025 links deliveries to devices with a trigger
and a backfill so the device filter is an indexed lookup.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /v1/notification-catalog: every notification a webhook can receive, with example payloads and route match fields.GET /v1/devices/{device_id}/notifications: routes that take the device's incidents (matches_because,matched_checks), webhook delivery health,would_firewith areason, and recent deliveries with payloads. Cursor paging,statusandevent_typefilters. Routes and webhooks carry their external refs.00025:webhook_delivery_devices, filled by a trigger and backfilled, so the device filter is an indexed lookup.Test plan
TestDeviceNotifications(new) and the fullgo test ./...suitego vet,gofmt🤖 Generated with Claude Code